From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= <stepnem@gmail.com>
Subject: Re: [PATCH 2/7] New macro: Evaluate FORM in ENVIRONMENT
Date: Tue, 02 Aug 2011 12:50:05 +0200
Message-ID: <87fwlk3x5u.fsf@gmail.com>
References: <1312277020-7888-1-git-send-email-dmaus@ictsoc.de>
	<1312277020-7888-3-git-send-email-dmaus@ictsoc.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:33058)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stepnem@gmail.com>) id 1QoCcW-0002rC-3L
	for emacs-orgmode@gnu.org; Tue, 02 Aug 2011 06:54:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stepnem@gmail.com>) id 1QoCcV-0002Hh-5h
	for emacs-orgmode@gnu.org; Tue, 02 Aug 2011 06:54:43 -0400
Received: from mail-fx0-f41.google.com ([209.85.161.41]:50082)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stepnem@gmail.com>) id 1QoCcU-0002HW-UQ
	for emacs-orgmode@gnu.org; Tue, 02 Aug 2011 06:54:43 -0400
Received: by fxg9 with SMTP id 9so7031404fxg.0
	for <emacs-orgmode@gnu.org>; Tue, 02 Aug 2011 03:54:42 -0700 (PDT)
In-Reply-To: <1312277020-7888-3-git-send-email-dmaus@ictsoc.de> (David Maus's
	message of "Tue, 2 Aug 2011 11:23:35 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: </archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: David Maus <dmaus@ictsoc.de>
Cc: emacs-orgmode@gnu.org

On Tue, 02 Aug 2011 11:23:35 +0200
David Maus wrote:

> * org-macs.el (org-eval-in-environment): New macro. Evaluate
> FORM in ENVIRONMENT.
> (org-with-uninterned): Move to top of file.
> ---
>  lisp/org-macs.el |   23 ++++++++++++++++++-----
>  1 files changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/org-macs.el b/lisp/org-macs.el
> index 53c60e5..7a0cc60 100644
> --- a/lisp/org-macs.el
> +++ b/lisp/org-macs.el
> @@ -47,6 +47,12 @@
>  (declare-function org-add-props "org-compat" (string plist &rest props))
>  (declare-function org-string-match-p "org-compat" (&rest args))
>=20=20
> +(defmacro org-with-uninterned (symbols &rest body)
> +  `(let ,(mapcar (lambda (s)
> +		   `(,s (make-symbol (symbol-name ',s)))) symbols)
> +     ,@body))
> +(put 'org-with-uninterned 'lisp-indent-function 1)
> +

So in the previous commit you added this macro, in the next commit you
move it to the top of the file? Why didn't you put it into the right
place to begin with?

[...]

> +(defun org-make-parameter-alist (flat)
> +  "Return alist based on FLAT.
> +FLAT is a list with alternating symbol names and values. The
> +returned alist is a list of lists with the symbol name in car and
> +the value in cdr."
> +  (when flat
> +    (cons (list (car flat) (cadr flat))
> +	  (org-make-parameter-alist (cddr flat)))))

This new function is not mentioned anywhere in the commit message.

--=20
=C5=A0t=C4=9Bp=C3=A1n