From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode Date: Tue, 06 Nov 2012 18:46:27 +0100 Message-ID: <87fw4m7hfw.fsf@gmail.com> References: <87liee7i60.fsf@gmail.com> <20121106174325.GA15586@c3po> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:52476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVnIQ-0004F3-Oq for emacs-orgmode@gnu.org; Tue, 06 Nov 2012 12:50:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TVnIP-0002Lv-BC for emacs-orgmode@gnu.org; Tue, 06 Nov 2012 12:50:42 -0500 Received: from mail-we0-f169.google.com ([74.125.82.169]:51508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVnIP-0002La-38 for emacs-orgmode@gnu.org; Tue, 06 Nov 2012 12:50:41 -0500 Received: by mail-we0-f169.google.com with SMTP id u3so401662wey.0 for ; Tue, 06 Nov 2012 09:50:40 -0800 (PST) In-Reply-To: <20121106174325.GA15586@c3po> (Toby Cubitt's message of "Tue, 6 Nov 2012 18:43:25 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Toby Cubitt writes: > Aha! You may well be right. In which case why is `org-beginning-of-line' > doing this: > > (if (org-bound-and-true-p line-move-visual) > (beginning-of-visual-line 1) > (beginning-of-line 1)) > > Shouldn't it be doing this instead? > > (if (org-bound-and-true-p visual-line-mode) > (beginning-of-visual-line 1) > (beginning-of-line 1)) Indeed. Do you want to provide a patch (you get bonus points for regression tests)? Regards,