From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [BUG] ob-sql.el: probably an extra paren Date: Wed, 20 Mar 2013 14:47:56 +0100 Message-ID: <87fvzqnpfd.fsf@bzg.ath.cx> References: <16047.1363748067@alphaville> <86vc8mtfcx.fsf@somewhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:54174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIJXc-0001qg-NL for emacs-orgmode@gnu.org; Wed, 20 Mar 2013 09:58:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIJXW-0004hG-Hd for emacs-orgmode@gnu.org; Wed, 20 Mar 2013 09:58:56 -0400 Received: from plane.gmane.org ([80.91.229.3]:37501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIJXW-0004h2-B9 for emacs-orgmode@gnu.org; Wed, 20 Mar 2013 09:58:50 -0400 Received: from public by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UIJXn-0004qE-6J for emacs-orgmode@gnu.org; Wed, 20 Mar 2013 14:59:07 +0100 In-Reply-To: <86vc8mtfcx.fsf@somewhere.org> (Sebastien Vauban's message of "Wed, 20 Mar 2013 13:39:26 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Sebastien Vauban Cc: public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org Hi Sébastien, "Sebastien Vauban" writes: > Nick Dokos wrote: >> Can we please make it an invariable practice to run `make test' before >> every push? > > Isn't it possible to put such in some sort of Git pre-commit hook (or pre-push > hook), so that it gets automatically enforced? If anyone knows how to setup an automated tests framework for Org, feel free to go ahead, we will use it and monitor broken tests to see what's wrong in the code or in the tests or in the environment running the tests. Testing is a nice habit to have, but let's not make it a coercive pre-requisit before pushing patches. My whole thinking here is well captured by Rich Hickey: http://codequarterly.com/2011/rich-hickey/ Fogus: You have been known to speak out against test-driven development. Do you mind elaborating on your position? Hickey: I never spoke out ‘against’ TDD. What I have said is, life is short and there are only a finite number of hours in a day. So, we have to make choices about how we spend our time. If we spend it writing tests, that is time we are not spending doing something else. Each of us needs to assess how best to spend our time in order to maximize our results, both in quantity and quality. If people think that spending fifty percent of their time writing tests maximizes their results—okay for them. I’m sure that’s not true for me—I’d rather spend that time thinking about my problem. I’m certain that, for me, this produces better solutions, with fewer defects, than any other use of my time. A bad design with a complete test suite is still a bad design. Best, -- Bastien