Re: ox-taskjuggler : Correct a small typo and deal with Scheduled and deadline in task

[Christian Egli <christian.egli@sbs.ch>]

Hi Baptiste

Thanks for the patch. It fixes a pretty bad oversight that you currently
apparently cannot define a start and an end using SCHEDULED and DEADLINE
(I thought this worked in the old exporter and was maybe lost in the
translation). I would like to use the patch but there are a couple of
issues:

Baptiste <bateast@bat.fr.eu.org> writes:

>           (effort (org-element-property :EFFORT task))
> +         (start (org-taskjuggler-get-start task))
> +         (end (org-taskjuggler-get-end task))

This is obviously OK.

> @@ -775,6 +777,14 @@ a unique id will be associated to it."
>               (org-taskjuggler-get-id task info)
>               (org-taskjuggler-get-name task))
>       ;; Add default attributes.
> +     (and milestone
> +          (cond
> +           ((and start end) (format "  start %s\n  maxend %s\n" start end))

Are you saying that if we have a milestone, a start and an end date we
should define the start and use the end date as a maxend? This seems
like an interesting approach. Unfortunately currently `milestone' is
true only if there is not both and start and an end date. We should
probably also change the definition of milestone (see
http://orgmode.org/cgit.cgi/org-mode.git/tree/contrib/lisp/ox-taskjuggler.el#n757).

> +           ((and start) (format "  start %s\n" start))

This looks a bit fishy. Shouldn't this be 

((start) (format "  start %s\n" start))

> +           ((and end) (format "  start %s\n" end))))
Ditto

Also we should probably change the definition of
`org-taskjuggler-get-start' to also look for a "start" attribute but
that's another story.

Can you fix these issues and resend?

Thanks
Christian

-- 
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland