Re: [PATCH] fix appointment warn time

[Bastien <bzg@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

Hi Ivan,

Ivan Kanis <banana@kanis.fr> writes:

> It seemed to be a boundary error. (point) was at the end of the
> timestamp which doesn't hold the org-appt-warntime property.

It does not hold the text property until this property has been
set.  E.g., `org-agenda-prepare-buffers' sets this property.

So I'm still curious: under which circumstances do you expect 
APPT_WARNTIME to have an effect while it does not?

`org-agenda-to-appt' do refresh the 'org-appt-warntime property,
so it will not appear here.

> foo.org illustrate what I have seen. Evaling the get-property sexp
> returns nil.

Yep, as expected.

> The patch adds a function that goes at the beginning of the header to
> get the property. As a bonus it turns the string into a number.
>
> Please let me know if the patch is accepted or needs improvement.

Can you try the attached patch instead?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org.el.patch --]
[-- Type: text/x-patch, Size: 362 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index 2bb6127..fe64f14 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9245,7 +9245,7 @@ property to set."
 	   (save-excursion
 	     (org-back-to-heading t)
 	     (put-text-property
-	      (point-at-bol) (point-at-eol) tprop p))))))))
+	      (point-at-bol) (org-end-of-subtree t t) tprop p))))))))
 
 
 ;;;; Link Stuff

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien