From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [Patch] ob-ditaa.el for Cygwin Date: Wed, 17 Jul 2013 08:21:36 -0600 Message-ID: <87fvvdl11r.fsf@gmail.com> References: <87ehb42tzc.fsf@gmail.com> <877ggw2szv.fsf@gmail.com> <87wqor3w5a.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzSdt-00064u-OA for emacs-orgmode@gnu.org; Wed, 17 Jul 2013 10:23:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzSdn-0000ni-3N for emacs-orgmode@gnu.org; Wed, 17 Jul 2013 10:23:45 -0400 Received: from mail-pb0-x235.google.com ([2607:f8b0:400e:c01::235]:59362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzSdm-0000nY-T7 for emacs-orgmode@gnu.org; Wed, 17 Jul 2013 10:23:39 -0400 Received: by mail-pb0-f53.google.com with SMTP id xb12so1952687pbc.26 for ; Wed, 17 Jul 2013 07:23:38 -0700 (PDT) In-Reply-To: <87wqor3w5a.fsf@Rainer.invalid> (Achim Gratz's message of "Tue, 16 Jul 2013 07:34:57 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Achim Gratz writes: > Yujie Wen writes: >> Could someone please take a look and, if it is satisfactory, please >> help to apply it? > > You're missing a Changelog and emacs-p might better be called cygwin-p. > > More to the point: I don't think Org should care about such system > idiosyncrasies at all. Instead you might use a wrapper script for > Cygwin that converts the arguments and then calls the native Windows > java executable. > >> I am used to Orgmode under Cygwin and sometimes uses ditaa for drawing >> diagrams. But without this patch, I have to switch to Windows native >> Emacs for calling ditaa. > > If there's anything to do on the Org side then removing the still > hardcoded call of "java". > I've just pushed up a configuration variable to allow customization of the previously hard coded "java". Set `org-babel-ditaa-java-cmd' to change this. > > > Regards, > Achim. -- Eric Schulte http://cs.unm.edu/~eschulte