Re: [PATCH] Improve message when file to include is missing

[Nicolas Goaziou <n.goaziou@gmail.com>]

Hello,

"Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
writes:

> When a SETUPFILE is missing, there is an error or message generated, but
> we don't know in which file the bad reference is -- when all those files
> are loaded during the agenda generation.
>
> Hence, a better message, specifying where to go and look for the bad
> link.

Thanks.

> From 4c31c1cf649c2eb3487e61e56296f058a62d7c08 Mon Sep 17 00:00:00 2001
> From: "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
> Date: Fri, 24 Jan 2014 11:43:52 +0100
> Subject: [PATCH] Improve message when file to include is missing
>
> * org.el (org-file-contents): Improve message when linked file does not exist.
>
> ---
>  lisp/org.el |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index a225bae..787a09f 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -5235,8 +5235,10 @@ Support for group tags is controlled by the option
>    (if (or (not file)
>  	  (not (file-readable-p file)))
>        (if noerror
> -	  (message "Cannot read file \"%s\"" file)
> -	(error "Cannot read file \"%s\"" file))
> +	  (message "Cannot read file \"%s\" referenced in file \"%s\""
> +		   file (buffer-file-name))
> +	(error "Cannot read file \"%s\" referenced in file \"%s\""
> +	       file (buffer-file-name)))

What if `buffer-file-name' returns nil? Sure, the problem won't happen
during agenda generation, but `org-file-contents' is used elsewhere.

Also, it is better to use:

  (buffer-file-name (buffer-base-buffer))

since the current buffer may be an indirect one.


Regards,

-- 
Nicolas Goaziou