From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Schulte <schulte.eric@gmail.com>
Subject: Re: Export arrays for 'sh' code blocks when using bash
Date: Mon, 14 Apr 2014 21:35:59 -0600
Message-ID: <87fvlfs1oh.fsf@gmail.com>
References: <CACc7+8asJQLQ3j=hCC-72quQTMt54E9dA=Wft6SrfP_pxyXkEQ@mail.gmail.com>
	<871txn1qni.fsf@bagel.gateway.pace.com>
	<CACc7+8bhg=ag8Mf6upY578a-s8_csTPv2Lbz8e39=h71Z+=CNA@mail.gmail.com>
	<871txkff89.fsf@gmail.com>
	<CA+p9wPBiZWEmFC+F-DFTUkDW1dMM-8q5o1NODdTwu2T3RsGo+Q@mail.gmail.com>
	<871tx4zj3i.fsf@gmail.com> <8761mg3sry.fsf@bzg.ath.cx>
	<CACc7+8bsTj-81T_BvEQsrWWFQDfW7keuZT-=ihvC_T-29dfuDw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39376)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1WZuBy-0005GK-RC
	for emacs-orgmode@gnu.org; Mon, 14 Apr 2014 23:37:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1WZuBu-0003Yq-Ba
	for emacs-orgmode@gnu.org; Mon, 14 Apr 2014 23:37:50 -0400
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Pascal Fleury <fleury@google.com>
Cc: Bastien <bzg@gnu.org>, Pascal Fleury <pascal@telefleuries.com>, emacs-orgmode@gnu.org

Pascal Fleury <fleury@google.com> writes:

> Hello,
>
> Great, thanks for the guidance. I hope I managed it all correctly.
>

I've applied this patch.

I made a couple of minor changes in a subsequent commit (a7189aa).
These were indentation and whitespace changes to enforce two coding
conventions,

1. limit line lengths to <80 characters
2. remove dangling parens on lines w/o any other text

and to rename one function to be specific to ob-shell.el.

Thanks for contributing!

>
> On Fri, Apr 11, 2014 at 11:33 AM, Bastien <bzg@gnu.org> wrote:
>
>> Hi Eric and Pascal,
>>
>> Eric Schulte <schulte.eric@gmail.com> writes:
>>
>> > Also, I think the google-wide copyright stuff is sorted out.
>>
>> Yes it is: we can accept patch from employees of Google, Inc.
>>
>>
> Good :-)
>
>
>> Pascal, I guess it's safe to assume anyone with a @google.com
>> email address is a Google employee -- let me know if it's not
>> the case.
>>
>>
> Yes, I checked internally, and this is a safe assumption.
>
>
>> Also, if you can sign your patches (git format-patch -s) that'd
>> be even better, but not mandatory.
>>
>>
> I did, also wrote the description of the patch according to the rules I
> found on orgmode.org
>
>
>> Thanks!
>>
>> --
>>  Bastien
>>
>
>
> Best regards,
> --paf
>

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D