emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric Schulte <schulte.eric@gmail.com>
To: Pascal Fleury <fleury@google.com>
Cc: Bastien <bzg@gnu.org>, Pascal Fleury <pascal@telefleuries.com>,
	emacs-orgmode@gnu.org
Subject: Re: Export arrays for 'sh' code blocks when using bash
Date: Mon, 14 Apr 2014 21:35:59 -0600	[thread overview]
Message-ID: <87fvlfs1oh.fsf@gmail.com> (raw)
In-Reply-To: CACc7+8bsTj-81T_BvEQsrWWFQDfW7keuZT-=ihvC_T-29dfuDw@mail.gmail.com

Pascal Fleury <fleury@google.com> writes:

> Hello,
>
> Great, thanks for the guidance. I hope I managed it all correctly.
>

I've applied this patch.

I made a couple of minor changes in a subsequent commit (a7189aa).
These were indentation and whitespace changes to enforce two coding
conventions,

1. limit line lengths to <80 characters
2. remove dangling parens on lines w/o any other text

and to rename one function to be specific to ob-shell.el.

Thanks for contributing!

>
> On Fri, Apr 11, 2014 at 11:33 AM, Bastien <bzg@gnu.org> wrote:
>
>> Hi Eric and Pascal,
>>
>> Eric Schulte <schulte.eric@gmail.com> writes:
>>
>> > Also, I think the google-wide copyright stuff is sorted out.
>>
>> Yes it is: we can accept patch from employees of Google, Inc.
>>
>>
> Good :-)
>
>
>> Pascal, I guess it's safe to assume anyone with a @google.com
>> email address is a Google employee -- let me know if it's not
>> the case.
>>
>>
> Yes, I checked internally, and this is a safe assumption.
>
>
>> Also, if you can sign your patches (git format-patch -s) that'd
>> be even better, but not mandatory.
>>
>>
> I did, also wrote the description of the patch according to the rules I
> found on orgmode.org
>
>
>> Thanks!
>>
>> --
>>  Bastien
>>
>
>
> Best regards,
> --paf
>

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D

  reply	other threads:[~2014-04-15  3:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27 10:26 Export arrays for 'sh' code blocks when using bash Pascal Fleury
2014-03-27 17:43 ` Eric Schulte
2014-03-27 22:52   ` Pascal Fleury
2014-03-29 19:37     ` Eric Schulte
2014-04-06 23:25       ` Pascal Fleury
2014-04-11  2:38         ` Eric Schulte
2014-04-11  9:33           ` Bastien
2014-04-14  8:48             ` Pascal Fleury
2014-04-15  3:35               ` Eric Schulte [this message]
2014-04-15 11:15                 ` Pascal Fleury
2014-04-22 14:47                 ` Skip Collins
2014-04-22 15:37                   ` Bastien
2014-04-22 17:19                     ` Skip Collins
2014-04-22 20:59                       ` Bastien
2014-04-22 21:04                         ` Skip Collins
2014-04-22 21:09                           ` Skip Collins
2014-04-22 21:22                             ` Bastien
2014-04-23 13:51                               ` Skip Collins
2014-04-23 14:13                                 ` Pascal Fleury
2014-04-23 16:31                                   ` Skip Collins
2014-04-24  1:23                                     ` Eric Schulte
2014-04-24  7:44                                       ` Pascal Fleury
2014-04-22 21:15                           ` Bastien
2014-04-15  3:37             ` Eric Schulte
2014-04-15 15:37               ` Nick Dokos
2014-04-17  6:31               ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvlfs1oh.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=fleury@google.com \
    --cc=pascal@telefleuries.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).