From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: [PATCH 2/2] Keep window position in agenda when changing todo
 states
Date: Sat, 14 Jun 2014 17:51:15 +0200
Message-ID: <87fvj78p70.fsf@bzg.ath.cx>
References: <1402757211-30510-1-git-send-email-bernt@norang.ca>	<1402757211-30510-3-git-send-email-bernt@norang.ca>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45507)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bounce+0e656e.a52ba-emacs-orgmode=gnu.org@bzg.fr>)
	id 1WvqEm-0001DS-L7
	for emacs-orgmode@gnu.org; Sat, 14 Jun 2014 11:51:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bounce+0e656e.a52ba-emacs-orgmode=gnu.org@bzg.fr>)
	id 1WvqEh-0007jj-67
	for emacs-orgmode@gnu.org; Sat, 14 Jun 2014 11:51:24 -0400
Received: from mail-s76.mailgun.info ([184.173.153.204]:54331)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bounce+0e656e.a52ba-emacs-orgmode=gnu.org@bzg.fr>)
	id 1WvqEg-0007jf-Uu
	for emacs-orgmode@gnu.org; Sat, 14 Jun 2014 11:51:19 -0400
In-Reply-To: <1402757211-30510-3-git-send-email-bernt@norang.ca>
	(Bernt	Hansen's message of "Sat, 14 Jun 2014 10:46:51 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org

Hi Bernt,

Bernt Hansen <bernt@norang.ca> writes:

> Allow changing task state in agenda without moving point.  I
> use this when reviewing projects weekly and I need to change the
> state of some of the tasks.  I found jumping to the top of the
> agenda after each state change especially annoying when it causes
> the agenda to scroll.

I think the bug this patches is supposed to fix (i.e. point jumping
at the top when changing the state of an agenda item) does not exist
anymore, neither in the maint branch nor in the master one.

Can you double-check?

Also, `save-window-excursion' is sort of a brute-force approach when
we only need to save the point position in a window.  There is a big
warning in `save-window-excursion' docstring that I slowly learned to
appreciate...

Anyway, I just looked at it quickly, maybe that's a correct fix.
Thanks for further confirmation.

-- 
 Bastien