From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: minor problem on major version number Date: Thu, 26 Jun 2014 19:44:09 +0200 Message-ID: <87fvira7me.fsf@Rainer.invalid> References: <871tubsl59.fsf@alphaville.bos.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Dis-0008RO-0T for emacs-orgmode@gnu.org; Thu, 26 Jun 2014 13:44:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0Dik-0007O1-ET for emacs-orgmode@gnu.org; Thu, 26 Jun 2014 13:44:33 -0400 Received: from plane.gmane.org ([80.91.229.3]:53832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Dik-0007NE-8X for emacs-orgmode@gnu.org; Thu, 26 Jun 2014 13:44:26 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1X0Dii-0004Sn-Sb for emacs-orgmode@gnu.org; Thu, 26 Jun 2014 19:44:24 +0200 Received: from pd9eb3c80.dip0.t-ipconnect.de ([217.235.60.128]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 26 Jun 2014 19:44:24 +0200 Received: from Stromeko by pd9eb3c80.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 26 Jun 2014 19:44:24 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nick Dokos writes: > After last night's git pull, org-version returns "beta_8.3" which > broke the major-version calculation above. I hardwired the org version > major number above, but I was wondering if we could agree on some > convention/method that will not break in the future - maybe an > org-major-version function? There already is a perfectly good convention available via C-h i version-to-list, which means the tag should have been named "release_8.3beta" and you do not need to invent your own version parsing code. Meanwhile, put these into local.mk: --8<---------------cut here---------------start------------->8--- GITVERSION ?= $(shell git describe --match release\* --abbrev=6 HEAD) ORGVERSION ?= $(subst release_,,$(shell git describe --match release\* --abbrev=0 HEAD)) --8<---------------cut here---------------end--------------->8--- I'm tempted to install that in targets.mk to avoid further breakage by malformed tags. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf rackAttack V1.04R1: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada