From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [BUG] org clock history no longer loaded from
 org-clock-persist-file
Date: Wed, 06 Jan 2016 15:10:26 +0100
Message-ID: <87fuyau7cd.fsf@nicolasgoaziou.fr>
References: <8760z98inz.fsf@fastmail.fm>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52118)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aGolL-00031j-D8
	for emacs-orgmode@gnu.org; Wed, 06 Jan 2016 09:08:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aGolK-0005jq-IV
	for emacs-orgmode@gnu.org; Wed, 06 Jan 2016 09:08:31 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:50135)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aGolK-0005ji-Ci
	for emacs-orgmode@gnu.org; Wed, 06 Jan 2016 09:08:30 -0500
In-Reply-To: <8760z98inz.fsf@fastmail.fm> (Matt Lundin's message of "Mon, 04
	Jan 2016 09:32:16 -0600")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Matt Lundin <mdl@imapmail.org>
Cc: Org Mode <emacs-orgmode@gnu.org>

Hello,

Matt Lundin <mdl@imapmail.org> writes:

> With the shift to lexical-binding in org-clock.el (commit
> 35bc1c8853c5cfe37930e3540a944a328af5198b), the function org-load-clock
> fails to load the stored data in org-clock-persist-file.
>
> These are the relevant setting in my .emacs:
>
> (setq org-clock-persist t)
> (setq org-clock-persist-file "~/data/org-clock-save.el")
> (org-clock-persistence-insinuate)
>
> Expected result: After calling the agenda for the first time, the
> variable org-clock-history is populated with data.
>
> Actual result: org-clock-history remains nil.
>
> As far as I can tell, the problem lies with the call to load-file (line
> 2986). Because of the lexical binding, the (setq stored-clock-history
> ....) statement stored in the org-clock-persist-file is evaluated but
> because of the lexical scoping it has no effect on the
> stored-clock-history in org-clock-load.

Fixed. Thank you for the detailed report.

Regards,

-- 
Nicolas Goaziou