From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oleh Krehel <oleh@oremacs.com>
Subject: Re: New package: ox-minutes [Please critique]
Date: Wed, 10 Aug 2016 18:16:07 +0200
Message-ID: <87fuqctxa0.fsf@oremacs.com>
References: <CAFyQvY3euwucYoz+RFXbEpBY1dHJ-1Ftrb0WaxT+4vqrfx=Zzg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56543)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ohwoeowho@gmail.com>) id 1bXWAz-0008Eu-EK
	for emacs-orgmode@gnu.org; Wed, 10 Aug 2016 12:16:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ohwoeowho@gmail.com>) id 1bXWAv-0004Oi-7c
	for emacs-orgmode@gnu.org; Wed, 10 Aug 2016 12:16:16 -0400
Received: from mail-wm0-f51.google.com ([74.125.82.51]:35750)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ohwoeowho@gmail.com>) id 1bXWAv-0004OO-1W
	for emacs-orgmode@gnu.org; Wed, 10 Aug 2016 12:16:13 -0400
Received: by mail-wm0-f51.google.com with SMTP id f65so99751113wmi.0
	for <emacs-orgmode@gnu.org>; Wed, 10 Aug 2016 09:16:10 -0700 (PDT)
In-Reply-To: <CAFyQvY3euwucYoz+RFXbEpBY1dHJ-1Ftrb0WaxT+4vqrfx=Zzg@mail.gmail.com>
	(Kaushal Modi's message of "Wed, 10 Aug 2016 15:19:14 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>

Kaushal Modi <kaushal.modi@gmail.com> writes:

> Hi all,
>
> I have never published a package. I generally write elisp snippets embedded in my config.
>
> Here are my first attempts at a 'package' and defining a custom org
> export backend.

Congrats on your first package! It will surely come in handy when
interacting with my less Emacs-enlightened colleagues. I recall one of
them writing very similar-looking notes in Microsoft Outlook. One or two
times I had to send them some notes, I actually did by hand the
transformation that `ox-minutes' now does.

> I would love to get criticism on this... What did I miss? Bad coding
> practices?

The coding looks fine. Just a suggestion: I think "\n" looks better than
a literal string newline.

It would be cool to have a regression test with:

    ./ox-minutes/ox-minutes-test.el
    ./ox-minutes/test_input.org
    ./ox-minutes/test_output.txt

Both test_input.org and test_output.txt could be moved from README.md.

regards,
Oleh