From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eduardo Bellani <ebellani@gmail.com>
Subject: Re: [PATCH] Fix clocktable scope parameter
Date: Thu, 15 Dec 2016 13:31:45 -0200
Message-ID: <87fulpus2m.fsf@gmail.com>
References: <8760ml2q30.fsf@gmail.com> <87y3zh5iu0.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44470)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ebellani@gmail.com>) id 1cHY1r-0008Lq-89
	for emacs-orgmode@gnu.org; Thu, 15 Dec 2016 10:33:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ebellani@gmail.com>) id 1cHY1o-0000cp-3u
	for emacs-orgmode@gnu.org; Thu, 15 Dec 2016 10:33:07 -0500
Received: from mail-vk0-f67.google.com ([209.85.213.67]:34262)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <ebellani@gmail.com>) id 1cHY1o-0000ch-06
	for emacs-orgmode@gnu.org; Thu, 15 Dec 2016 10:33:04 -0500
Received: by mail-vk0-f67.google.com with SMTP id p9so7950812vkd.1
	for <emacs-orgmode@gnu.org>; Thu, 15 Dec 2016 07:33:03 -0800 (PST)
In-reply-to: <87y3zh5iu0.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode <emacs-orgmode@gnu.org>, Eduardo Bellani <ebellani@gmail.com>

--=-=-=
Content-Type: text/plain

Hello Nicolas,

I agree with you about introducing 'eval' into the code base. This was
just me getting the code from 8.3 back in a format the current code
understand. Which leads me to conclude that this is not new
functionality, just old undocumented functionality. I've found out about
it through this SE post: http://emacs.stackexchange.com/a/7903

Anyway, I'll modify the patch and include documentation for this
functionality.

Nicolas Goaziou writes:

> Hello,
>
> Eduardo Bellani <ebellani@gmail.com> writes:
>
>> org-clock.el: Fix clocktable scope parameter
>>
>> * lisp/org-clock.el (org-dblock-write:clocktable): Make sure to eval
>>   the scope if it is a lisp expression, or to return the scope if it
>>   is just a list.
>>
>> This adds back to the clocktable the capacity to have as scope both a
>> list of file paths or a function that returns such a list.
>
> Thank you.
>
> However, I'd rather not introduce more `eval' in the code base.
>
> Instead, you can test if scope is a function and `funcall' it.  This is
> a new feature, which would require some documentation and an entry in
> ORG-NEWS.
>
> Regards,

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlhSt2EACgkQSbLl0kCTjGmBjgCfZirdE/Vw+bVO2ETg0UwvXRDj
BVEAmQHajCRVi4IeIkZoaoGI8oDr1WZe
=2EcB
-----END PGP SIGNATURE-----
--=-=-=--