emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Change in appearance of org-todo-keywords
@ 2017-08-03 16:42 Colin Baxter
  2017-08-03 18:33 ` Adam Porter
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Colin Baxter @ 2017-08-03 16:42 UTC (permalink / raw)
  To: emacs-orgmode


Hello,

As of today, TODO now appears with three sets of un-requested double
colons after it, as in TODO :: :: ::

The behaviour doesn't occur with emacs -q, so the cause is presumably in
my ~/.emacs. I can't work out what's wrong with my org-todo-sequence,
which is:

(setq org-todo-keywords (quote((sequence "TODO(t)" "STARTED(s)"
				"NEXT(n@/!)" "WAITING(w@/!)"
				"HOLD(h@/!)" "CANCELLED(c@/!)"
				"PHONE(p)"  "BREAK(b)" "MEETING(m)" "DONE(d@/!)"
				))))

Also, HOLD now appears as a tag when I change from TODO to HOLD. Any
suggestions as to how I might begin tracking down the cause? It's
driving me nuts.

Thanks.

Colin.

-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-03 16:42 Change in appearance of org-todo-keywords Colin Baxter
@ 2017-08-03 18:33 ` Adam Porter
  2017-08-03 19:54   ` Colin Baxter
  2017-08-07  4:16 ` Josh Moller-Mara
  2017-08-09 14:03 ` Colin Baxter
  2 siblings, 1 reply; 14+ messages in thread
From: Adam Porter @ 2017-08-03 18:33 UTC (permalink / raw)
  To: emacs-orgmode

I don't mean this in a snide way, but do you keep your config in version
control?  e.g. if you have it stored in git, you can bisect it and find
the change that caused the problem.

Other than that, you can probably find the problem using the bug-hunter
package.  It can bisect your init file and find the lisp form that's
causing it.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-03 18:33 ` Adam Porter
@ 2017-08-03 19:54   ` Colin Baxter
  2017-08-03 22:11     ` Adam Porter
  0 siblings, 1 reply; 14+ messages in thread
From: Colin Baxter @ 2017-08-03 19:54 UTC (permalink / raw)
  To: Adam Porter; +Cc: emacs-orgmode

Dear Adam,
>>>>> Adam Porter <adam@alphapapa.net> writes:

    > I don't mean this in a snide way, but do you keep your config in
    > version control?  e.g. if you have it stored in git, you can
    > bisect it and find the change that caused the problem.

    > Other than that, you can probably find the problem using the
    > bug-hunter package.  It can bisect your init file and find the
    > lisp form that's causing it.

Thanks for the suggestion, but I think I may be missing something. My
emacs init has not changed. My org keyword settings have worked for a
few years satisfactorily - until that is today. I think I need to bisect
org-mode to find the case? I've tried reverting a couple of recent
org-mode commits but to no avail.

Best wishes,

Colin.

-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-03 19:54   ` Colin Baxter
@ 2017-08-03 22:11     ` Adam Porter
  0 siblings, 0 replies; 14+ messages in thread
From: Adam Porter @ 2017-08-03 22:11 UTC (permalink / raw)
  To: emacs-orgmode

Colin Baxter <m43cap@yandex.com> writes:

> Thanks for the suggestion, but I think I may be missing something. My
> emacs init has not changed. My org keyword settings have worked for a
> few years satisfactorily - until that is today. I think I need to bisect
> org-mode to find the case? I've tried reverting a couple of recent
> org-mode commits but to no avail.

Oh, I didn't realize you were on Org's bleeding edge.  ;)  If Org's the
only thing that's changed, then yeah, a git bisect should find it.

You might try with "emacs -q" first (loading the current Org files
manually).

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-03 16:42 Change in appearance of org-todo-keywords Colin Baxter
  2017-08-03 18:33 ` Adam Porter
@ 2017-08-07  4:16 ` Josh Moller-Mara
  2017-08-07  6:31   ` Colin Baxter
  2017-08-07  9:31   ` Malcolm Purvis
  2017-08-09 14:03 ` Colin Baxter
  2 siblings, 2 replies; 14+ messages in thread
From: Josh Moller-Mara @ 2017-08-07  4:16 UTC (permalink / raw)
  To: Colin Baxter, emacs-orgmode

Colin Baxter <m43cap@yandex.com> writes:

> As of today, TODO now appears with three sets of un-requested double
> colons after it, as in TODO :: :: ::
>
> The behaviour doesn't occur with emacs -q, so the cause is presumably in
> my ~/.emacs. I can't work out what's wrong with my org-todo-sequence,
> which is:
>
> (setq org-todo-keywords (quote((sequence "TODO(t)" "STARTED(s)"
> 				"NEXT(n@/!)" "WAITING(w@/!)"
> 				"HOLD(h@/!)" "CANCELLED(c@/!)"
> 				"PHONE(p)"  "BREAK(b)" "MEETING(m)" "DONE(d@/!)"
> 				))))

This is happening with me too. But I suspect it has more to do with
org-todo-state-tags-triggers being set. I don't get the double colons if
I don't set org-todo-state-tags-triggers.

From what I can tell, doing something like (org-toggle-tag "sometag"
'off) produces these double colons. It seems to have to do with the way
that org-split-string no longer returns nil, but returns ("").

Best,
Josh

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-07  4:16 ` Josh Moller-Mara
@ 2017-08-07  6:31   ` Colin Baxter
  2017-08-07  9:39     ` Nicolas Goaziou
  2017-08-07  9:31   ` Malcolm Purvis
  1 sibling, 1 reply; 14+ messages in thread
From: Colin Baxter @ 2017-08-07  6:31 UTC (permalink / raw)
  To: Josh Moller-Mara; +Cc: emacs-orgmode

Dear Josh,
>>>>> "Josh" == Josh Moller-Mara <jmm@cns.nyu.edu> writes:

    Josh> Colin Baxter <m43cap@yandex.com> writes:
    >> As of today, TODO now appears with three sets of un-requested
    >> double colons after it, as in TODO :: :: ::
    >> 
    >> The behaviour doesn't occur with emacs -q, so the cause is
    >> presumably in my ~/.emacs. I can't work out what's wrong with my
    >> org-todo-sequence, which is:
    >> 
    >> (setq org-todo-keywords (quote((sequence "TODO(t)" "STARTED(s)"
    >> "NEXT(n@/!)" "WAITING(w@/!)"  "HOLD(h@/!)" "CANCELLED(c@/!)"
    >> "PHONE(p)" "BREAK(b)" "MEETING(m)" "DONE(d@/!)"  ))))

    Josh> This is happening with me too. But I suspect it has more to do
    Josh> with org-todo-state-tags-triggers being set. I don't get the
    Josh> double colons if I don't set org-todo-state-tags-triggers.

    Josh> From what I can tell, doing something like (org-toggle-tag
    Josh> "sometag" 'off) produces these double colons. It seems to have
    Josh> to do with the way that org-split-string no longer returns
    Josh> nil, but returns ("").

    Josh> Best, Josh

Yes, you are correct. I can confirm that switching off
org-todo-state-tags-triggers removes the insertion of colons for me too.

Thank you.

Best wishes,

Colin.

-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-07  4:16 ` Josh Moller-Mara
  2017-08-07  6:31   ` Colin Baxter
@ 2017-08-07  9:31   ` Malcolm Purvis
  1 sibling, 0 replies; 14+ messages in thread
From: Malcolm Purvis @ 2017-08-07  9:31 UTC (permalink / raw)
  To: emacs-orgmode

>>>>> "Josh" == Josh Moller-Mara <jmm@cns.nyu.edu> writes:

Josh> From what I can tell, doing something like (org-toggle-tag
Josh> "sometag" 'off) produces these double colons. It seems to have to
Josh> do with the way that org-split-string no longer returns nil, but
Josh> returns ("").

I'm also seeing this problem and I have org-todo-state-tags-triggers
set.

A git bisect points the finger at this commit, which also agrees your
observations about org-split-string.

commit f776e65373fa135fffb51e201698823fbfb3865b (refs/bisect/bad)
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date:   Thu Jul 27 13:39:52 2017 +0200

    Move `org-split-string' to "org-macs.el"

    * lisp/org.el (org-split-string): Move the function...
    * lisp/org-macs.el (org-split-string): ... here.  Also clarify
      docstring with regards to `split-string'.

Malcolm

-- 
	       Malcolm Purvis <malcolm@purvis.id.au>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-07  6:31   ` Colin Baxter
@ 2017-08-07  9:39     ` Nicolas Goaziou
  2017-08-07 10:18       ` Colin Baxter
  2017-08-07 11:01       ` Josh Moller-Mara
  0 siblings, 2 replies; 14+ messages in thread
From: Nicolas Goaziou @ 2017-08-07  9:39 UTC (permalink / raw)
  To: Colin Baxter; +Cc: emacs-orgmode, Josh Moller-Mara

Hello,

Colin Baxter <m43cap@yandex.com> writes:

> Yes, you are correct. I can confirm that switching off
> org-todo-state-tags-triggers removes the insertion of colons for me
> too.

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-07  9:39     ` Nicolas Goaziou
@ 2017-08-07 10:18       ` Colin Baxter
  2017-08-07 11:01       ` Josh Moller-Mara
  1 sibling, 0 replies; 14+ messages in thread
From: Colin Baxter @ 2017-08-07 10:18 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode, Josh Moller-Mara

Dear Nicolas,

>>>>> "Nicolas" == Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

    Nicolas> Hello, Colin Baxter <m43cap@yandex.com> writes:

    >> Yes, you are correct. I can confirm that switching off
    >> org-todo-state-tags-triggers removes the insertion of colons for
    >> me too.

    Nicolas> Fixed. Thank you.

    Nicolas> Regards,

    Nicolas> -- Nicolas Goaziou


Thank you. I can confirm that my org-todo-keywords are now appearing as
normal.

Best wishes,

Colin.

-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-07  9:39     ` Nicolas Goaziou
  2017-08-07 10:18       ` Colin Baxter
@ 2017-08-07 11:01       ` Josh Moller-Mara
  2017-08-07 11:49         ` Colin Baxter
  1 sibling, 1 reply; 14+ messages in thread
From: Josh Moller-Mara @ 2017-08-07 11:01 UTC (permalink / raw)
  To: Nicolas Goaziou, Colin Baxter; +Cc: emacs-orgmode



Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> Colin Baxter <m43cap@yandex.com> writes:
>
>> Yes, you are correct. I can confirm that switching off
>> org-todo-state-tags-triggers removes the insertion of colons for me
>> too.
>
> Fixed. Thank you.
>

Hello,

~org-toggle-tag~ now seems to delete currently set tags for a heading. It
seems that calling ~(match-string 1)~ after ~(replace-match "")~ makes
the former return an empty string, so the ~current~ tags get set as an
empty string. It also still seems to set a blank tag ("::") if there was
a tag set previously.

Best,

Josh

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-07 11:01       ` Josh Moller-Mara
@ 2017-08-07 11:49         ` Colin Baxter
  0 siblings, 0 replies; 14+ messages in thread
From: Colin Baxter @ 2017-08-07 11:49 UTC (permalink / raw)
  To: Josh Moller-Mara; +Cc: emacs-orgmode, Nicolas Goaziou

Dear Josh,
>>>>> "Josh" == Josh Moller-Mara <jmm@CNS.NYU.EDU> writes:

    Josh> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
    >> Hello,
    >> 
    >> Colin Baxter <m43cap@yandex.com> writes:
    >> 
    >>> Yes, you are correct. I can confirm that switching off
    >>> org-todo-state-tags-triggers removes the insertion of colons for
    >>> me too.
    >> 
    >> Fixed. Thank you.
    >> 

    Josh> Hello,

    Josh> ~org-toggle-tag~ now seems to delete currently set tags for a
    Josh> heading. It seems that calling ~(match-string 1)~ after
    Josh> ~(replace-match "")~ makes the former return an empty string,
    Josh> so the ~current~ tags get set as an empty string. It also
    Josh> still seems to set a blank tag ("::") if there was a tag set
    Josh> previously.

Ah yes, I spoke too soon. I am now seeing what you report.

Sorry Nicolas, It isn't fixed completely.

-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-03 16:42 Change in appearance of org-todo-keywords Colin Baxter
  2017-08-03 18:33 ` Adam Porter
  2017-08-07  4:16 ` Josh Moller-Mara
@ 2017-08-09 14:03 ` Colin Baxter
  2017-08-09 17:00   ` Adam Porter
  2 siblings, 1 reply; 14+ messages in thread
From: Colin Baxter @ 2017-08-09 14:03 UTC (permalink / raw)
  To: emacs-orgmode

>>>>> Colin Baxter <m43cap@yandex.com> writes:

    > Hello,

    > As of today, TODO now appears with three sets of un-requested
    > double colons after it, as in TODO :: :: ::

    > The behaviour doesn't occur with emacs -q, so the cause is
    > presumably in my ~/.emacs. I can't work out what's wrong with my
    > org-todo-sequence, which is:

    > (setq org-todo-keywords (quote((sequence "TODO(t)" "STARTED(s)"
    > "NEXT(n@/!)" "WAITING(w@/!)"  "HOLD(h@/!)" "CANCELLED(c@/!)"
    > "PHONE(p)" "BREAK(b)" "MEETING(m)" "DONE(d@/!)"  ))))

    > Also, HOLD now appears as a tag when I change from TODO to
    > HOLD. Any suggestions as to how I might begin tracking down the
    > cause? It's driving me nuts.

These colons now appear in agenda habits, so the "fix" of 07 Aug 2017
doesn't work. To make them disappear or at least not appear, I must not
associate any tags with the habit.

Considering how fundamental keywords and tags are to org-mode, I'm a
little surprised that only two other users have reported the issue.


-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-09 14:03 ` Colin Baxter
@ 2017-08-09 17:00   ` Adam Porter
  2017-08-10  9:04     ` Colin Baxter
  0 siblings, 1 reply; 14+ messages in thread
From: Adam Porter @ 2017-08-09 17:00 UTC (permalink / raw)
  To: emacs-orgmode

Colin Baxter <m43cap@yandex.com> writes:

> Considering how fundamental keywords and tags are to org-mode, I'm a
> little surprised that only two other users have reported the issue.

It's because of the bravery of users like you that I don't run master.
;)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Change in appearance of org-todo-keywords
  2017-08-09 17:00   ` Adam Porter
@ 2017-08-10  9:04     ` Colin Baxter
  0 siblings, 0 replies; 14+ messages in thread
From: Colin Baxter @ 2017-08-10  9:04 UTC (permalink / raw)
  To: Adam Porter; +Cc: emacs-orgmode

Dear Adam,
>>>>> "Adam" == Adam Porter <adam@alphapapa.net> writes:

    Adam> Colin Baxter <m43cap@yandex.com> writes:
    >> Considering how fundamental keywords and tags are to org-mode,
    >> I'm a little surprised that only two other users have reported
    >> the issue.

    Adam> It's because of the bravery of users like you that I don't run
    Adam> master.  ;)

You might have a point there!

-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2017-08-10  9:05 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-03 16:42 Change in appearance of org-todo-keywords Colin Baxter
2017-08-03 18:33 ` Adam Porter
2017-08-03 19:54   ` Colin Baxter
2017-08-03 22:11     ` Adam Porter
2017-08-07  4:16 ` Josh Moller-Mara
2017-08-07  6:31   ` Colin Baxter
2017-08-07  9:39     ` Nicolas Goaziou
2017-08-07 10:18       ` Colin Baxter
2017-08-07 11:01       ` Josh Moller-Mara
2017-08-07 11:49         ` Colin Baxter
2017-08-07  9:31   ` Malcolm Purvis
2017-08-09 14:03 ` Colin Baxter
2017-08-09 17:00   ` Adam Porter
2017-08-10  9:04     ` Colin Baxter

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).