From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Subject: Re: TIMEZONE property for ical export
Date: Sat, 19 Aug 2017 12:56:40 -0700
Message-ID: <87fucns553.fsf@ericabrahamsen.net>
References: <87ziawx1f7.fsf@ericabrahamsen.net>
	<87fucolzv5.fsf@nicolasgoaziou.fr> <87a82vv5up.fsf@ericabrahamsen.net>
	<87k21zjr6x.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59649)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1dj9rg-0002k5-3m
	for emacs-orgmode@gnu.org; Sat, 19 Aug 2017 15:57:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1dj9rd-0004Ja-1T
	for emacs-orgmode@gnu.org; Sat, 19 Aug 2017 15:57:00 -0400
Received: from [195.159.176.226] (port=51360 helo=blaine.gmane.org)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <geo-emacs-orgmode@m.gmane.org>)
	id 1dj9rc-0004JR-RB
	for emacs-orgmode@gnu.org; Sat, 19 Aug 2017 15:56:56 -0400
Received: from list by blaine.gmane.org with local (Exim 4.84_2)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1dj9rR-0006aI-5k
	for emacs-orgmode@gnu.org; Sat, 19 Aug 2017 21:56:45 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>>> BTW, as long as Org doesn't support time zones, the "ox-icalendar"
>>> property may be prefixed with "ICALENDAR_" (e.g., ICALENDAR_TZ).
>>
>> Done!
>
> I realize this is not a great idea since other properties do not have
> "ICALENDAR_" prefix. Sorry about that. I suggest to go back to TIMEZONE.

No problem.

>> How does the attached patch look?
>
>> -	     (cat (org-icalendar-get-categories entry info)))
>> +	     (cat (org-icalendar-get-categories entry info))
>> +	     (tz (org-element-property :ICALENDAR_TZ entry)))
>
> Note that "ICALENDAR_TZ" is not inherited in this case. Neither are
> LOCATION and so on, tho. You would need to use
> `org-export-get-node-property' in conjunction with
> `org-property-inherit-p'.

It's a little strange, because the manual section for this specifically
mentions the inheritance of the LOCATION property, but the code doesn't
do it. Shall I add it in? It makes sense for LOCATION and TIMEZONE to be
inheritable, but not SUMMARY and DESCRIPTION, of course.

If I add inheritance, that will look like this, right?

(tz (org-export-get-node-property :LOCATION entry
                                  (org-property-inherit-p :LOCATION)))

That could also be a separate, second commit.

>> -event belongs to.
>> +event belongs to. TIMEZONE specifies a time zone for this event
>> +only.
>
> Missing space.
>
> Could you add a commit message and an ORG-NEWS entry?

I've added an ORG-NEWS entry. The patch in my last message was done with
git format-patch, isn't that commit message okay?

Eric