Re: Arithmetic range error

[Colin Baxter <m43cap@yandex.com>]

[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]

>>>>> Kyle Meyer <kyle@kyleam.com> writes:

    > Colin Baxter <m43cap@yandex.com> writes:
    >> Publishing an org file today, the html output looks ok but I get
    >> the compilation error:
    >> 
    >> Arithmetic range error: "floor", 1549541220.7500212
    >> 
    >> I get the error with org-version 9.2.1
    >> (release_9.2.1-200-g18b85a) but not with org-version 8.2.10.
    >> 
    >> Looking at 'org-publish-cache-ctime-of-src' in the file
    >> `ox-publish.el', its not obvious to me where the error is coming
    >> from. Ditto after looking in NEWS and the git commit logs.
    >> 
    >> Can anyone help?

    > This looks to be due to the backport of Emacs's 662bee7d7,
    > specifically:

    > * lisp/ox-publish.el (org-publish-cache-ctime-of-src): Prefer
    > float-time to doing time arithmetic by hand.  [...]  @@ -1364,8
    > +1366,7 @@ (defun org-publish-cache-ctime-of-src (file)
    > (expand-file-name (or (file-symlink-p file) file)
    > (file-name-directory file))))) (if (not attr) (error "No such
    > file: \"%s\"" file) - (+ (ash (car (nth 5 attr)) 16) - (cadr (nth
    > 5 attr)))))) + (floor (float-time
    > (file-attribute-modification-time attr))))))

    > I won't have a chance to investigate further though until (my EST)
    > tonight.

I can now confirm that if the above commit is reversed then my
Arithmetic range error disappears.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: test.patch --]
[-- Type: text/x-diff, Size: 560 bytes --]

diff --git a/lisp/ox-publish.el b/lisp/ox-publish.el
index d9fc8d2..2144aa1 100644
--- a/lisp/ox-publish.el
+++ b/lisp/ox-publish.el
@@ -1366,7 +1366,9 @@ does not exist."
 	       (expand-file-name (or (file-symlink-p file) file)
 				 (file-name-directory file)))))
     (if (not attr) (error "No such file: \"%s\"" file)
-      (floor (float-time (file-attribute-modification-time attr))))))
+      (+ (ash (car (nth 5 attr)) 16)
+	 (cadr (nth 5 attr))))))
+;;      (floor (float-time (file-attribute-modification-time attr))))))
 
 
 (provide 'ox-publish)

[-- Attachment #3: Type: text/plain, Size: 46 bytes --]


Best wishes,

Colin Baxter
m43cap@yandex.com