From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: [PATCH] Add semimonth step for clocktables Date: Thu, 26 Mar 2020 03:36:21 +0000 Message-ID: <87ftdvss7e.fsf@kyleam.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:60661) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHJK0-0004B0-EB for emacs-orgmode@gnu.org; Wed, 25 Mar 2020 23:36:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHJJz-0004gV-2p for emacs-orgmode@gnu.org; Wed, 25 Mar 2020 23:36:44 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:57433) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jHJJy-0004fG-QO for emacs-orgmode@gnu.org; Wed, 25 Mar 2020 23:36:43 -0400 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Christian Hopps Cc: emacs-orgmode@gnu.org Thanks for the patch. The change looks fine to me. A few things: * Please update the commit message to follow the instructions at . * Please send git-format-patch output either via git-send-email or as an attachment. (At least with my usual git-am incantations, the best I was able to do with this email's patch was to make a commit with the proper change but with an empty commit message, including the subject.) * In my opinion it'd be better to send this patch as a follow-up to the thread for the initial patch at . That way, the conversation stays in one place, and those that gave feedback initially are more likely to see the follow-up and provide additional feedback. Could you send an updated patch to the original thread? Thanks.