emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Christian Hopps <chopps@chopps.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add semimonth step for clocktables
Date: Thu, 26 Mar 2020 03:36:21 +0000	[thread overview]
Message-ID: <87ftdvss7e.fsf@kyleam.com> (raw)
In-Reply-To: <sa68sjvfede.fsf@stubbs.int.chopps.org>

Thanks for the patch.  The change looks fine to me.

A few things:

  * Please update the commit message to follow the instructions at
    <https://orgmode.org/worg/org-contribute.html>.

  * Please send git-format-patch output either via git-send-email or as
    an attachment.  (At least with my usual git-am incantations, the
    best I was able to do with this email's patch was to make a commit
    with the proper change but with an empty commit message, including
    the subject.)

  * In my opinion it'd be better to send this patch as a follow-up to
    the thread for the initial patch at
    <https://lists.gnu.org/archive/html/emacs-orgmode/2020-03/msg00115.html>.
    That way, the conversation stays in one place, and those that gave
    feedback initially are more likely to see the follow-up and provide
    additional feedback.

Could you send an updated patch to the original thread?

Thanks.

      reply	other threads:[~2020-03-26  3:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 11:35 [PATCH] Add semimonth step for clocktables Christian Hopps
2020-03-26  3:36 ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftdvss7e.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=chopps@chopps.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).