From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4AdWElZuBF/nZQAA0tVLHw (envelope-from ) for ; Tue, 07 Jul 2020 12:45:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2AwhDlZuBF8jPgAAB5/wlQ (envelope-from ) for ; Tue, 07 Jul 2020 12:45:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B100E940C60 for ; Tue, 7 Jul 2020 12:45:09 +0000 (UTC) Received: from localhost ([::1]:42778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsmyB-00025g-MZ for larch@yhetil.org; Tue, 07 Jul 2020 08:45:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsmxq-00025a-Qn for emacs-orgmode@gnu.org; Tue, 07 Jul 2020 08:44:46 -0400 Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:52852 helo=ciao.gmane.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsmxp-000351-43 for emacs-orgmode@gnu.org; Tue, 07 Jul 2020 08:44:46 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1jsmxk-0002r8-NH for emacs-orgmode@gnu.org; Tue, 07 Jul 2020 14:44:40 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Nick Dokos Subject: Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list Date: Tue, 07 Jul 2020 08:44:34 -0400 Message-ID: <87fta3xznx.fsf@alphaville.usersys.redhat.com> References: <87o8osxevq.fsf@alphaville.usersys.redhat.com> <87v9j054ya.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cancel-Lock: sha1:kCIYxURwd2LyH1DAmpKSuJSkwKY= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/07 08:44:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 30 X-Spam_score: 3.0 X-Spam_bar: +++ X-Spam_report: (3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, FUZZY_DR_OZ=1, HEADER_FROM_DIFFERENT_DOMAINS=1, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.41 X-TUID: uuTGjwEfNOlH Hi Kyle, thanks for the review. Kyle Meyer writes: > Nick Dokos writes: > >> Here's a patch to enhance the property name completion list with names from >> #+PROPERTY keyword lines: at the moment, only property names found in property >> drawers are used to populate the completion list. > > Thanks for the patch. > >> org: add property names from #+PROPERTY keywords to completion list >> >> * lisp/org.el (org-buffer-property-keys): ehhance the completion list > > Typo: enhance. And as a convention nit, it should be capitalized. > Fixed. >> with property names from #+PROPERTY keywords, not just property >> drawers. >> >> ... >> + (mapcar (lambda (s) >> + (let ((split (split-string s))) >> + (nth 0 split))) >> + (cdar (org-collect-keywords '("PROPERTY")))) >> nil))) > > IMO the let-binding doesn't add any clarity over > > (nth 0 (split-string s)) > Fixed. > > I wondered about possible duplicates, but it looks like > org-buffer-property-keys already takes care of that at the end. > > I think this patch is a clear improvement as is, but in the context of > completion (and the stack exchange post you link to), isn't the handling > around *_ALL keywords still a bit off? It seems a caller would want to > complete without the _ALL; to use the example from that post, with > "#+PROPERTY: GENRE_ALL ...", the caller would want to complete "GENRE". > Is it worth providing special handling here? > > My assumption was that one could put in two properties (that's what the OP was doing in his setup file): a GENRE_ALL one already properly set-up and the corresponding bare GENRE property as a placeholder with an empty value, just to get the completion. It seems to me like a reasonable way to do it, without making org-buffer-property-keys too opinionated. I could see stripping all the _ALL suffixes from the property names at the end, but personally it just makes me a bit queasy :) But if there is consensus one way or the other, I'd be happy to implement it. Here's the updated patch: --8<---------------cut here---------------start------------->8--- >From 50c625f935d5581952d37801943550ff44c473ff Mon Sep 17 00:00:00 2001 From: Nick Dokos Date: Mon, 6 Jul 2020 21:49:41 -0400 Subject: [PATCH] org: add property names from #+PROPERTY keywords to completion list * lisp/org.el (org-buffer-property-keys): Enhance the completion list with property names from #+PROPERTY keywords, not just property drawers. See https://emacs.stackexchange.com/questions/59448/ for details. --- lisp/org.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/org.el b/lisp/org.el index 4a1a83d0f..8deaa1ed9 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -13084,6 +13084,10 @@ COLUMN formats in the current buffer." (props (append (and specials org-special-properties) (and defaults (cons org-effort-property org-default-properties)) + ;; Get property names from #+PROPERTY keywords as well + (mapcar (lambda (s) + (nth 0 (split-string s))) + (cdar (org-collect-keywords '("PROPERTY")))) nil))) (org-with-wide-buffer (goto-char (point-min)) -- 2.25.1 --8<---------------cut here---------------end--------------->8--- -- Nick "There are only two hard problems in computer science: cache invalidation, naming things, and off-by-one errors." -Martin Fowler