From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id nn8AFs/9CGBWBAAA0tVLHw (envelope-from ) for ; Thu, 21 Jan 2021 04:06:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GkB6Ec/9CGDGXAAAB5/wlQ (envelope-from ) for ; Thu, 21 Jan 2021 04:06:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BD6E9940341 for ; Thu, 21 Jan 2021 04:06:38 +0000 (UTC) Received: from localhost ([::1]:42474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2REz-0000tR-4b for larch@yhetil.org; Wed, 20 Jan 2021 23:06:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2REa-0000tG-IB for emacs-orgmode@gnu.org; Wed, 20 Jan 2021 23:06:12 -0500 Received: from out2.migadu.com ([2001:41d0:2:aacc::]:15405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2REW-0003YY-VJ; Wed, 20 Jan 2021 23:06:12 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1611201961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BJQSm/WR56ZWLNPivpCwW6DmIRbywnue8Md55e8iERY=; b=LuuHkKdTxpmPf6OEQisglJ9Zp2c6Lv3ehnU2kL4w2QltPJ3EuAOCFJRNcJOso28GhHMKXm 7tMgUwKyR5k1bpgulqLWn2h3GakkIggsSlPsoVQLmPZp2ZpFnB/Cg6SyIKpnpH/5Vxsaxk UjpO81wHSFN6khGxVdLVtTApQuJsoFt9njaFikAI8wc0STCAZkj4fNm44qBpSGQkSINFXL +g7UaglMhU167guW3QXY76Q4JOkNVDxC4/qKbZSymNIwhdlIsVSnnL95iJ+cQvurk34oJj BIwfUPP6GjI/WJpEHFgi4gaIi6PrMl7+SnEiNz6FMximEzx2KBmGQRDAME8TnQ== From: Kyle Meyer To: TEC Subject: Re: [PATCH] Enhance org-html--build-meta-info References: <87pn6kfr19.fsf@gmail.com> <87sgb28gd8.fsf@wi.uni-muenster.de> <87blexel9f.fsf@gmail.com> <87im94ordh.fsf@gnu.org> <87tusolntx.fsf@wi.uni-muenster.de> <873607uw3y.fsf@gmail.com> <87im928ck3.fsf@wi.uni-muenster.de> <87k0tidxcf.fsf@gmail.com> <875z5287v1.fsf@wi.uni-muenster.de> <877dpdukkp.fsf@gmail.com> <84wnxccqa3.fsf@wi.uni-muenster.de> <874kjzb25d.fsf@gmail.com> <8735ziup6f.fsf@wi.uni-muenster.de> <87czymt6n1.fsf@gmail.com> <87zh1qrps8.fsf@wi.uni-muenster.de> <87ble5ucqk.fsf@gmail.com> <87ble5gort.fsf@wi.uni-muenster.de> <87o8hwpz34.fsf@gmail.com> <87lfd0hgi7.fsf@wi.uni-muenster.de> <87mtxgplz8.fsf@gmail.com> <87pn27st06.fsf@gmail.com> X-Woof-Patch: applied Date: Wed, 20 Jan 2021 23:05:59 -0500 In-Reply-To: <87pn27st06.fsf@gmail.com> (TEC's message of "Thu, 14 Jan 2021 18:36:54 +0800") Message-ID: <87ft2vszmg.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=kyle@kyleam.com; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Lechtenboerger , Bastien , org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.55 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=LuuHkKdT; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: BD6E9940341 X-Spam-Score: -2.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: SKrqJu2/T29a TEC writes: > TEC writes: > > Sorry about that, here's an actual revision. Thanks, this series is a good improvement as far as I can tell. And thank you Jens for all of the careful reviews. I've applied this (a8df7670c) with two minor changes (shown in the diff at end): s/with with/with/ in a docstring and move an element to its own line to avoid the warning from lisp-mode's lisp--match-hidden-arg. This thread has gone on long enough that I'll avoid requesting changes for convention/style nits, but some things to keep in mind for future patches: * Your changes replace several `and's with `when's as well as a one-armed if. The previous code is following the style/preference of using `and' in cases where the return value is of interest, leaving `when' for side effects. As mentioned in the message below (just the first example I found when searching the list), it's definitely a matter of taste and not a hard rule, but please try to stick with that convention. https://orgmode.org/list/87d23sdtod.fsf@nicolasgoaziou.fr/ * Please avoid adding blank lines within function definitions. * Please follow the project's convention of capitalizing the first word after ": " in the commit message subject. Also, it'd be good for this to be accompanied by a NEWS entry. I'd appreciated if that were sent in a separate thread, though. For some reason I haven't debugged, my usual MUA can't load this thread. Thanks again. diff --git a/lisp/ox-html.el b/lisp/ox-html.el index bd2ca1753..11757bb35 100644 --- a/lisp/ox-html.el +++ b/lisp/ox-html.el @@ -1431,8 +1431,8 @@ (defcustom org-html-meta-tags #'org-html-meta-tags-default Can be a list where each item is a list of arguments to be passed to `org-html--build-meta-entry'. Any nil items are ignored. -Also accept a function which gives such a list when called with with -a single argument (INFO, a communication plist)." +Also accept a function which gives such a list when called with a +single argument (INFO, a communication plist)." :group 'org-export-html :package-version '(Org . "9.5") :type '(choice @@ -1937,7 +1937,8 @@ (defun org-html--build-meta-info (info) (lambda (args) (apply #'org-html--build-meta-entry args)) (delq nil (if (functionp org-html-meta-tags) (funcall org-html-meta-tags info) - org-html-meta-tags)) "")))) + org-html-meta-tags)) + "")))) (defun org-html--build-head (info) "Return information for the .. of the HTML output.