From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0r.migadu.com with LMTPS id Ym1QAtE2jWDHUAEALuJCtg (envelope-from ) for ; Sat, 01 May 2021 13:09:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 0MwVOdA2jWBXGAAA1q6Kng (envelope-from ) for ; Sat, 01 May 2021 11:09:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E6DF219AFA for ; Sat, 1 May 2021 13:09:03 +0200 (CEST) Received: from localhost ([::1]:37776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcnUc-0003Zq-6o for larch@yhetil.org; Sat, 01 May 2021 07:09:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcnTr-0003Zk-6e for emacs-orgmode@gnu.org; Sat, 01 May 2021 07:08:15 -0400 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:42977) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcnTp-0005y3-JE for emacs-orgmode@gnu.org; Sat, 01 May 2021 07:08:14 -0400 Received: by mail-pf1-x42e.google.com with SMTP id b27so853649pfp.9 for ; Sat, 01 May 2021 04:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=29gn37zmIqeVHMLu+z+C/xvkpDGudxehY8uE5io1VRc=; b=bUG9XbjuUwD50CDUEBU/joxXRnTVTxKWjn3fxChPaesdk8S2glxqs/Y5PRfAQTiCtx 0ZNEtPI5bB9nqyayo125ThiYJlEHD3K/O6976CRw0h0x/58OwwT6QXhOg9YSP9Yyf2BN kDSeXxf0oSk/bG/pr6ueGwX5uAgeRVXRyd4nNm+Ap6WPm3LbbkwCHGgIa+bCS/b2pRlv l3yrMFTqyVJqxZMIa4zR+UvVDMLB1mtPhjvuSc0clHasNPWth6dIrMrD47bzDVyUHfaT 7ZtyT9UIxmuHaKNSQs2IetwCye4c9U+NktZFduIZF4s5G5Gsz2jeXqWJLzMhZTuuro91 ofuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=29gn37zmIqeVHMLu+z+C/xvkpDGudxehY8uE5io1VRc=; b=sH6ewshJ0bZzs/LaSwNt0Z8kwsSuL2bi357Y5YXKbm1tUMiXS8idBgXpaRCxzJDQ92 vPgPR7D29H0HKoAkn2HTEZSsc4PqD0RZnS8cn4nrPMDWUre1QEnx5BNc43MHY/zRHfyW Zr3VZ9/GMpOSINXauv78l05HHi4av+jrJi+fTbHaBludiLgcmcVqCoc8a+9tcBBSugyM 5CkFNm/FEsbF2KNh7y3w30Bc5Bm0Ic+aAe1bxuiHHSvE9OJ8uFzbJ/809BPgyp/UBRmR USHGBHr9i51dbND7b1iwDSHzlsNug0xBdsprBHZJkJx7MZasxJOV3JCvsY0taT1p9huk LKgQ== X-Gm-Message-State: AOAM531e+NFPB8t/e9X9zKIZ2y796wsEunkLg+ZAeP9stjShNGse69/d yh4arVo91swQ5MlKea+2nxBiYhpke68= X-Google-Smtp-Source: ABdhPJzjSKJ0pLT4rWD7Qp9Bk/zda+RAK8C/2cgz80X18NIDAMneT/A5iG2xYYXViN9G+CtPTfKEgA== X-Received: by 2002:a65:560d:: with SMTP id l13mr8997086pgs.49.1619867291737; Sat, 01 May 2021 04:08:11 -0700 (PDT) Received: from localhost (180-150-91-8.b4965b.per.nbn.aussiebb.net. [180.150.91.8]) by smtp.gmail.com with ESMTPSA id e5sm5108107pgj.91.2021.05.01.04.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 May 2021 04:08:11 -0700 (PDT) References: <87o8et6g79.fsf@tsdye.online> User-agent: mu4e 1.4.15; emacs 28.0.50 From: Timothy To: "Thomas S. Dye" Subject: Re: [PATCH] LaTeX export: arbitrary float environments In-reply-to: <87o8et6g79.fsf@tsdye.online> Message-ID: <87fsz6k8yw.fsf@gmail.com> Date: Sat, 01 May 2021 19:08:07 +0800 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=tecosaur@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619867344; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=29gn37zmIqeVHMLu+z+C/xvkpDGudxehY8uE5io1VRc=; b=OZqlQlBGro3ZAKJnMlEvQf3a7MpsZjVCfbyprz/vU6+VKX1t+s8Y3qDya0C02ZAZLgqfye j84Dsyd4OLEKfNHFPASY+CXlRtiXwqNFJZrLesNojEDjTd9rS6SzK1i9Cuu62GQPGk5Jka NsmXZRINpuzt7sQAsBtqrirQFnLUT5dFd5oRb5Z6spKY1XLrk9FpMbfNDs67PmbdW4pxFh QduE8sA77dy9oOwAmQQhU9crq8Q0vmVXfIAv9UuTkvIV4L9MyWqC+3ia6R0Y4593YmhRJ/ u97m7lXWDleWIwVCmlya74gArSpnci+jbwm4kSY4cXBnRM8HEwZmgcfyA0KKKQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619867344; a=rsa-sha256; cv=none; b=Yb5JGfLWRQGvLQunPJQYtjym78RwbbxgBA46UkS0mivp2UxmYqWrYvkC/Ay1/sLiNTEfIT dBnSdexskjkxlswcp+Zkfid/uyGwCG0KNGFxi4J60GhhWnaRiigOOSjGFgIwI0ipon4tz5 mx2f1qfUByf6W9dqIag6EolXKSRzHMdKEGK1Njgjl8Uii+rIGwNTl4yiGTqWnnvBp0dzae PZ4Ead2oqZSMFLfhS0CuDe5a4GB64G0RdqW5kztLllJ/ozgxv1Cu6K0MnXYhl+VQRRcy7a HhsHrDipdM/b4In0Rv5uUedt622KUxdLl7dp57eFxhdY+FEfIOOYAtrx9XsRoA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=bUG9Xbju; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.16 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=bUG9Xbju; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E6DF219AFA X-Spam-Score: -3.16 X-Migadu-Scanner: scn0.migadu.com X-TUID: NZGZuoD1TQ/z Hi Thomas, On the surface, this looks reasonable to me :) Just commenting on some technicalities with the patch itself: - In ORG-NEWS it would be good to wrap the content over multiple lines instead of having a single 270 char line :) - You seem to have an anomalous change to the ob-python :return entry - I don't think your patch subject follows the convention for Org, it should be: "main file/feature: overall change summary" so, something like "ox-latex: allow for arbitrary float environments" rather than "LaTeX export: arbitrary float environments" Thanks for the patch :) Timothy