From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6FIGIwWmuGInAAAAbAwnHQ (envelope-from ) for ; Sun, 26 Jun 2022 20:31:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oHAJIgWmuGI82gAAG6o9tA (envelope-from ) for ; Sun, 26 Jun 2022 20:31:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03D5966EE for ; Sun, 26 Jun 2022 20:31:33 +0200 (CEST) Received: from localhost ([::1]:46318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5X2i-0008E4-2X for larch@yhetil.org; Sun, 26 Jun 2022 14:31:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5Wpp-0003oS-Ft for emacs-orgmode@gnu.org; Sun, 26 Jun 2022 14:18:13 -0400 Received: from out2.migadu.com ([2001:41d0:2:aacc::]:25892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5Wpl-0006zO-JX for emacs-orgmode@gnu.org; Sun, 26 Jun 2022 14:18:12 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1656267487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C6jzKLcUIGC/Ztbt1qqOviLqbQ5xckKUW1kYEek4uD4=; b=gEvQv+6F4KEK+YteiS6l5cDOfNKbHn++FBVJbYs54jaZSwmBJLcod0iRLVgOFrdbOBvSGz E84oOldrdQ31ZRRoYbd2XAD8COvpEtRW1JF/43NPmDcT9zBfV3ZtIT+g8n2A+NEc9F36Ox hlARvA9WJHxxWDAP8WPkYlNouLVAZc/ks3w8hx7mzLXpDo4OqOXIxIVRl9PTLSaJwLa/Wn Gc10bmq0frjuBk7xaO7wMG+8mBn6OYeMfgrv0h/24r2kgrBpXX8jO6+uQbXlPfgXBAnHgU Dhd9m9U20xCK9zw1gALnAqkQ9TwuLeUPz9JvSPdEX/izr4Qv/T2slVLNxlaiww== From: Kyle Meyer To: Daniel Fleischer Cc: Ihor Radchenko , emacs-orgmode@gnu.org, emacs@vergauwen.me Subject: Re: [PATCH] Re: ox-latex table tabbing support. In-Reply-To: References: <87wng5nno3.fsf@localhost-Mzo7eKN----2> <87zgi0tcj6.fsf@localhost> <87k09413uc.fsf@kyleam.com> Date: Sun, 26 Jun 2022 14:18:02 -0400 Message-ID: <87fsjr1e79.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=kyle@kyleam.com; helo=out2.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656268293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=C6jzKLcUIGC/Ztbt1qqOviLqbQ5xckKUW1kYEek4uD4=; b=Uf8/c9tavVSQNdyvWSXFdXYyQNlpsw3/4pi00Ma/UQXE7vucQBLZcWJ2x2osc6lwogUYYP VXz1oAnf3VHHv3G6STMsyijFIAjZ4L/8lTYDSJOAgCq/MRWtKsJqfhz4TY0RQ8ZG0uxl1O EKfYhAD6qN+TKrF1I0fWgLXJHuJMMLSfwbgv18AyxzrOLpXWv6T2zoMOi7Ha6ZKRs8oFry ovbTDDSwKzOOaCf8FCaWdQE2QStiLt4WMyq0gnC13Oz+DHy2mPq8DROP+1oZjM7AY9NCUl qWa0hF67ejTDAd3eoE27eDJMNBMRz6Fp+3hfZEdp2Oy78OODUmk1W+8hQ9HawA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656268293; a=rsa-sha256; cv=none; b=ZeNCJhIJtqZ37Dq7gQG4pKWOoqd0G3ohEiSXfAZshgf8NPzktKnz0wJC0HcKa400F/RUZV z2amebi6ih055f8DtiM2Y/biGdGLC0GJYC/Bz9hXbUwjiRDNCHGyOkyM49yJEEuee9IuuY L62oj2F6cIWdq4TwA8e0lc9hP7dkCZHs0m8q10/fIndSmdYKHPFF9h58oeu141+LYb/IP+ 6qODW8IQ7ABu7fk80n990z0SljtrREpqds6friE2YBJtuErXhMvdSJQWayClQlhCRhXPE9 6GrV2BbXLTTEcLpU55rZwCGAiQYi/imcHO0gRFV2/uUVtROHbORw4+c7Cq679w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=gEvQv+6F; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.96 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=gEvQv+6F; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 03D5966EE X-Spam-Score: -1.96 X-Migadu-Scanner: scn1.migadu.com X-TUID: /L8cQrOLMkMf Thanks for the follow-up patch. Daniel Fleischer writes: > Subject: [PATCH] lisp/ox-latex.el: tabbing code refactor > > * lisp/ox-latex.el: documentation, indentation, cleaning > (org-latex-table) > (org-latex--align-string-tabbing) > (org-table--org-tabbing) This format doesn't quite align to the conventions. Here are two examples: ,----[ https://orgmode.org/worg/org-contribute.html#commit-messages ] | * lisp/org-capture.el (org-capture-set-plist): Make sure txt is a | string before calling `string-match'. | (org-capture-templates): Fix customization type. `---- ,----[ https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs ] | * lisp/term.el (term-emulate-terminal): Avoid errors if the whole | decoded string is eight-bit characters. Don't attempt to save the | string for next iteration in that case. | * test/lisp/term-tests.el (term-decode-partial) | (term-undecodable-input): New tests. `---- [...] > + (or (org-export-read-attribute :attr_latex table :align) > + (let* ((count > + ;; Count the number of cells in the first row. > + (length > + (org-element-map > + (org-element-map table 'table-row > + (lambda (row) > + (and (eq (org-element-property :type row) > + 'standard) > + row)) > + info 'first-match) > + 'table-cell > + (lambda (cell) cell)))) Fine as is, but (lambda (cell) cell) could be reduced to #'identity > + ;; Calculate the column width, using a proportion of > + ;;the documets textwidth. nit: missing space before "the" typo: documets -> document's > +(defun org-table--org-tabbing (table contents info) > + "Return tabbing environment latex code for Org table. Perhaps s/latex/LaTeX/ for consistency? Otherwise, looks good to me. Thanks again.