From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UGFPO+VdpGNwqQAAbAwnHQ (envelope-from ) for ; Thu, 22 Dec 2022 14:38:46 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mBYbO+VdpGP39QAAauVa8A (envelope-from ) for ; Thu, 22 Dec 2022 14:38:45 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 77F28CE79 for ; Thu, 22 Dec 2022 14:38:45 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p8LlV-0006Ry-0R; Thu, 22 Dec 2022 08:37:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8LlT-0006RR-0b for emacs-orgmode@gnu.org; Thu, 22 Dec 2022 08:37:39 -0500 Received: from mail-yqbcan01on20716.outbound.protection.outlook.com ([2a01:111:f403:7052::716] helo=CAN01-YQB-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8LlQ-0004mV-II for emacs-orgmode@gnu.org; Thu, 22 Dec 2022 08:37:38 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KYjIzD/uN368GEEe/47Z1Cub8PkzyRQhHgEePxeQRA2l2GUMksUkcM7X1SJjJPNjY77saeLrlG6GWm6s4WadShRE03TBjzK1/gjJfRknfaY2Hqu8Vb9Y7SewQl0GRNr+surGvO74HF8DrB4nMBskkpINbhegWA/022zeHiQgrW9maqjrWkkL9HNLJ62vhCuonKd7CLHfKxBhTfObdL/8sU7t9EsPvi0vzP5okL5os328otwqSY2yNYYiJUuCjBKz++acc3RzVjAPsYML34dfwVm9O32Dul5a8IKkWbmuZ35xkf6XS5Eiczc7vs+FN4p8lZemUvGjRRfgJThEhJ//Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lY0u5lZVHXdEfTvBAt7i+wzHlrGYwdba5QHDsU7kfwA=; b=Eido7Wmma/bZ2Nr/dDYiUr8v48DwTKr7hUlyLD539kd6okw7pNgji375faC2+8ooRnx0e2Bu1pfaxiiSiEiiwLO9pWauKG0hzp4URmgtjjV2Pe60AbnQIGzxomMq8cfS/5xDHK8y1blVaTOSFJTMNw80fV/szVgb4om0mR9jDbvsowpJyhb9vuYzzIp826/nV4SIq/aQ1po9pnYor0UZ5gj/3JgKUSi0kVzKgWQ5EzaGa0FyNgKTQB0rAGbeAbpgdGA98E5P/IKC7QnP5urH3Y8DO2FEBFZNm44b/f6tumT7iDqL+dk5ev3A62y50BR+QkKiqUbuNnswFBDGbHLVOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=umanitoba.ca; dmarc=pass action=none header.from=umanitoba.ca; dkim=pass header.d=umanitoba.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umanitoba.onmicrosoft.com; s=selector2-umanitoba-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lY0u5lZVHXdEfTvBAt7i+wzHlrGYwdba5QHDsU7kfwA=; b=al+yNdxC784lOebyahsgpevDhD7gr3SJYAUB4o/v7oNE6ZGiYwaEXCtgbEcnmTiUMDXTOfj+HzfY/1nLwcSgQqHKCD+Cctsrwl9Z9as1UiKJZi1imoutbAB8fVeFCUJGIpGznCouLZeF7XDZA/+KmIvisqjKT3ApkU9rC4XhBRo= Received: from YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:90::5) by YQBPR0101MB5783.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:32::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Thu, 22 Dec 2022 13:32:30 +0000 Received: from YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM ([fe80::ee0c:56b6:8f8b:2d1]) by YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM ([fe80::ee0c:56b6:8f8b:2d1%7]) with mapi id 15.20.5944.012; Thu, 22 Dec 2022 13:32:30 +0000 From: Leo Butler To: Ihor Radchenko CC: Org Mode Mailing List Subject: Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects Thread-Topic: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects Thread-Index: AQHY8srL9HYY78NwOki4MB+cHbDIhw== Date: Thu, 22 Dec 2022 13:32:30 +0000 Message-ID: <87fsd7wolt.fsf@t14.reltub.ca> References: <87mt92elyy.fsf@t14.reltub.ca> <87mt9128sz.fsf@localhost> <87zgd1b4rn.fsf_-_@t14.reltub.ca> <8735asbtfe.fsf@localhost> <87pmdvamwf.fsf@t14.reltub.ca> <87bkpaguy3.fsf@localhost> <87leocuhpg.fsf@t14.reltub.ca> <87359esah2.fsf@localhost> <87cz8ifioa.fsf@localhost> <87sfh9vukl.fsf@localhost> In-Reply-To: <87sfh9vukl.fsf@localhost> (Ihor Radchenko's message of "Wed, 21 Dec 2022 11:56:42 +0000") Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: YT3PR01MB9964:EE_|YQBPR0101MB5783:EE_ x-ms-office365-filtering-correlation-id: 146b8107-c115-434e-f246-08dae420f9de x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mTjz+xgcvlub9rf/pDB0zwwhUbDCw+WuOdB4KeMWjvGCgQy4gdDaOHP8jdGEdK72epkBxL5gW8F9WjYcG4TaB4a4ZODeB8whaZXxVgn3G1ZAf48RmofLuFRBX2MoESkorNWjQnHFE5SpPpVeZtbnWV5dVxUpuWaxTDsDFOugZIFgEsYhVCOmSY0obb9qp357LHz6NtB8lRGNtDEuE+WQUf5+vBC3ovja7R5iy/TfFDvVXNg8Z4BLEww1AKSwPJu1pMKgFnUKBHbKYTkRo5C1mVOI6BX7mlDPN7VJx9q0cS8SneOMwBsUBXU5gly9B9eNIszVmngl1Qq0gYKOkpYPz7mV1jo8DJWlpOk+Ycq99T0dZ429LJyFFMB3wv+16T4tGE7O5BZgZ9yhwUmr/GAvTIW07V6C4xc5ZI7IAM+SZ/vSr6YWUUMndx31ztQ7LeOxzuqZrvjsK0WV+JWnK2JdjsFd+1JacHA+G122SbwukTM/ZmZOU2h6sPBOcg8e9yfuqvd7s87STWE6gNyiEvDtsQfzYgAzf24mJ5Kfpr2z51bQBl787VqpuWMZmMaIkZiyPTaCp23Ax92gpJ0AMzDosDAg4KweLJUVx4sulFW/bZ1cNSSRgae12VIsuy0fNmaUFi01upQD+94urzKQ+xScdNp90PMs9ABpMXNjZFrzATYaw5r1EGUa4aOdwZECWhGbfTvywFlYNCFM/DqGKJjiergzDz763gJsGwQ3zpsz7nY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(346002)(396003)(376002)(39860400002)(366004)(136003)(451199015)(66476007)(66446008)(66556008)(4326008)(64756008)(91956017)(76116006)(8676002)(316002)(5660300002)(786003)(8936002)(86362001)(66946007)(41300700001)(41320700001)(9686003)(6506007)(186003)(6512007)(71200400001)(26005)(83380400001)(38070700005)(6916009)(38100700002)(122000001)(966005)(478600001)(6486002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?H/vcnAFa7z3lS7CtISigE5WzeG5ItxLkFdCZ+RGvxHTOCQj8O6bEPO492S?= =?iso-8859-1?Q?1uyplDjJh+K3NWas2i1qQhW9ZUx6sa5jLBWgCnNmOAi0NFUFTZPNtRSPgE?= =?iso-8859-1?Q?7Ac/E0crCNAH5kR2aEit0KKcRN085lcbA9bMozmLLCeFYmJXgeutkdfZaG?= =?iso-8859-1?Q?wx3Gs1MLNO54Fc/DqC2i5aK3MpIaHJ42c9jw6+2Bt+gFXBNC/7XiMdd4FI?= =?iso-8859-1?Q?0iHSseyhT4iasMK4SCvh3eaScDKJdck+aO82t4gDil8WUDC+VacSqPuWwS?= =?iso-8859-1?Q?wGYnLv6DMnfgds0/j7qELs3OqHBkqW/BkNxNpzfzDeYyHEcXXV9qsjl425?= =?iso-8859-1?Q?QoYDA7FD0rsaH93Bv9BPCe/l37BrkFE4Q0K4x4amDtYwrqGyEG/QUYC+kg?= =?iso-8859-1?Q?irdElu4Q8rzbplMNw1Oxks0m//oJJoh1JJT2V6/Y+JBAVWz2U79yYBfVyp?= =?iso-8859-1?Q?gOQwEVDVoLikzzZ1jZZPBF1BCcnkXzIMnCPM/IpSKJVa+MVl9IfcLzTQ2R?= =?iso-8859-1?Q?QfsyPALbX9/9Md82GgiB5C7zXewZq+2X1JPyJ10zotJnQQd+bNpJDvl1e/?= =?iso-8859-1?Q?e2o7T/DCcRWJRTW6fyPPeZJ71I6pVwiBuK7D2iiE2R5dFouxKK/F4mPYXA?= =?iso-8859-1?Q?KiAanhE2rA/FLhx2LfD3iD5hPy3luO56vxCJ73ifCSPbxCZi8+DWbX4vvf?= =?iso-8859-1?Q?RIIeUnh6JHE8+4qrjAJjiV/DoYIC217ob0G+E0rGL82vDC9qhGKylCAdKE?= =?iso-8859-1?Q?rN0jd5tsqJe+Kzsv/bPhspYaSWudlsHKs4zKYNmuWJAy50YplXoG6yLsZB?= =?iso-8859-1?Q?jTDWZtU77KdiyMjdHAT7yDWJ22N8VMVVkD2oUEzAzRFL3lPJNK9GBNIfGS?= =?iso-8859-1?Q?pBImq7PiZLVmp+9VvQQ8ppzAP5gdtzOOdHwY/DzA9W8J9KeJWmV4ZyIpTy?= =?iso-8859-1?Q?flBuGL750w0h+/JCkhYG3fD1sHg9sWg+fNOE8nNrL/lYQKNEzCis57JHQG?= =?iso-8859-1?Q?AmBzjVeq1rBemdG8wBV41ZoDM5Y0c7Nsl8e7DxGrsxLCaWYZqQ3DU5Ue8S?= =?iso-8859-1?Q?tpmPoYIrWUcejBajhdpUy2fg27Wy3F4yN10PAHTFhVw3/01H6GSvXMuDpP?= =?iso-8859-1?Q?fFRee0GMJlnkRI/obv6vOiT/9rPCFroovtyukVNoMMZHfwWh6l6QcO5ZJH?= =?iso-8859-1?Q?j37hoxDQfmMsD1D4tIiixYDqwejFspXDg9H/KPuzsGCbY8hLZORdJ27+fh?= =?iso-8859-1?Q?Tr4spgl6lGvMbNl1x86GM0z27F3DrAA9doXobMCZ6HM8aPi2F6koA738/2?= =?iso-8859-1?Q?9sr0+5ylBSZXccNES+6fxFlqqj/Lpj3nI42SCf5iaLsFHCgqaPZrAF8ZEz?= =?iso-8859-1?Q?5b7kz3v9u7II2Eqmg1vhuh+1xpuP32O/BVG89aFpqIYeYShv8/cW+DFjBa?= =?iso-8859-1?Q?vBmCL2gnMj7KAmvKT5goELRKvy7/j9zMyDomoTNDxHOdfMZkg1m82prCT1?= =?iso-8859-1?Q?JGWQYNjJhciK8+lBAHblK3hqL2ZKxc6YPo3Z2sVe1SmJX/QCxaxyLUSO7B?= =?iso-8859-1?Q?+vu2ZfpHrPP/FgQPOKTdmQLyrDduDnFENORlhkbYinoMEOI3s70neGqDHm?= =?iso-8859-1?Q?6HqQhtbCIzAEIpcMJdTtjvAA+CFWQCTJtyms0LMZ8bmf3zGsCsWcMiuA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: umanitoba.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 146b8107-c115-434e-f246-08dae420f9de X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2022 13:32:30.8258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4f80dd0b-338c-4e4c-8a14-90446962f7b8 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +7HLEHvSbp6YtlrHmbpTyvtZGHubukKCHr6Tj3GF8loo9J4/S6l1bA3wb3LHe01p1LVPbA8hVaa+6usbkAEhfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB5783 Received-SPF: pass client-ip=2a01:111:f403:7052::716; envelope-from=Leo.Butler@umanitoba.ca; helo=CAN01-YQB-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671716325; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=lY0u5lZVHXdEfTvBAt7i+wzHlrGYwdba5QHDsU7kfwA=; b=UrjnBXUYD3psqre6PplgZ+1G/xKI2QVvcFVTi6CG95atyynwC6YirsPcH4BdX6qKbRC46L VKUQEg5Sw4QgVKbtsfwk/67DzqtMC9vbxlzlCB5P1UzeAVgcVPNbkiE1nir6lHg1xjpcMv sRQAsa4r8YO/cpEYYn/zizxjrX492R2s2AL9P7UYrZXjNQZtWEAWjehyL3JBJx/c090k7q Iy77bNefbN1sLi7obFs7fjXBaFv7lZP04+tYLuBKNRzHbGacc56N8SKS3leATRT7w6EdJI l3nyS/fWlmueZy/ZIG2YfPulxOxegBH9umtmDh0mtcomwkdiA8b1/96tNB0E0Q== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=umanitoba.onmicrosoft.com header.s=selector2-umanitoba-onmicrosoft-com header.b=al+yNdxC; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=2; s=key1; d=yhetil.org; t=1671716325; a=rsa-sha256; cv=pass; b=VB3vwSraU6miwQuM/LnmJIhSVqh6rVL928WYXokrEwG8XeJXf8sf7cdBlSqlQbX1SVo/Qd 70Ts4fVyTILrBhBT8Cv68f6o9/IUs0ox8XTbnpbCB/MK/DpKiyr6Dzr/JCBK8iBdwT2ND0 NHjwMPM1V6PBG66nj8JBrsQiY/tUwlliLoGEPRwI1CtK5zdT6bR75FE3Ux3VdiVNlr7Uuf PCfBmxDfT2lmlH8wf3p9aDdvTXgaKhI3UIsVow98xMT11JPZgyorgqDBig2fGXL+AK1ys4 oLcObGmlKD2w+nysS75nWOFmNsP/kt7m3qHUn+GKHRYe2q+0y9Mm0T9hqEPrRg== X-Spam-Score: -5.13 X-Migadu-Queue-Id: 77F28CE79 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=umanitoba.onmicrosoft.com header.s=selector2-umanitoba-onmicrosoft-com header.b=al+yNdxC; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -5.13 X-TUID: VhOacchk7qSC On Wed, Dec 21 2022, Ihor Radchenko wrote: > Ihor Radchenko writes: > >>> Upon confirming the FSF copyright assignment, I have applied the patch >>> onto bugfix. >>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3D01c0e= bee2 >> >> Your patch appears to not work in some environments: >> >> https://builds.sr.ht/~bzg/job/906710 >> >> Any ideas? > > Note that the tests are failing only partially. The graphics file does > get created, but it has 0 size for some reason. Maybe something to do > with non-graphical CI environment. There is a race condition between writing the contents of the graphics file to disk and emacs checking the file size. My guess is that this is causing the problem (and that the same failure applies for emacs-2{6,7}, since only the emacs-28 reports the exact test failure). > > I disabled the tests for the time being until we figure out what is > going on. > > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3Da29103a= 78 That's pretty crude. Here are a couple thoughts: - Is there a way to detect that the tests are running in this CI environment? We could use that to skip the file-size test selectively. - Alternatively, we could remove the file-size test entirely. Either option seems better than not running the tests at all. Leo=