From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AAOuF+6deWRI3QAASxT56A (envelope-from ) for ; Fri, 02 Jun 2023 09:44:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EILJF+6deWSgsgAA9RJhRA (envelope-from ) for ; Fri, 02 Jun 2023 09:44:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1DF88E7C7 for ; Fri, 2 Jun 2023 09:44:46 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4zRq-00055L-7K; Fri, 02 Jun 2023 03:43:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4zRn-00054P-Os for emacs-orgmode@gnu.org; Fri, 02 Jun 2023 03:43:43 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4zRl-0000sU-Mf for emacs-orgmode@gnu.org; Fri, 02 Jun 2023 03:43:43 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1349B240103 for ; Fri, 2 Jun 2023 09:43:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1685691819; bh=Zz4wVFrk4chybSKBBRT0hq0cav7byPB7RnYzUqOl9Rw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=oVHna8bPNCkhZxaIO3ZL/GD+HRNGw/p8FBR5QnTBKF9ezDeFJ45LdtLXGp9pxUeh9 Ncd+25BVL4+Q+y4eOWIUdAlUxd55X4HikxBzPW0J3CPXtDWD2/NFb/LMbU6CEJ2NHA lasoyYv4Lrpn5KYq8eQLY4adktEKNse6BbZVj/x2otqlEorgOSlNBtR6ncRX+KgDe1 uEtnMajIf+uv15G4ty0qPp5A4+Ub5WhRlouXcVRgTWa1pWH3kr+4lbwR6M5imHeMmZ 89lYo7WX8mhk2N6+B53Y3MZkuMT6SQZuVGgtj1ugAwwnHicNkDeB/ODYoAx+UfxaUQ R+IAEqFP//g+A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QXZkL3hhnz9rxN; Fri, 2 Jun 2023 09:43:38 +0200 (CEST) From: Ihor Radchenko To: Steven Allen Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org.el: inline display of attached images in link descriptions In-Reply-To: <20230601191303.71002-1-steven@stebalien.com> References: <20230601191303.71002-1-steven@stebalien.com> Date: Fri, 02 Jun 2023 07:48:10 +0000 Message-ID: <87fs7a5mpx.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685691886; a=rsa-sha256; cv=none; b=LF1d7HsGWiZmo9Olct9xZkXxNahnusS+BfRy+d8BlQpL+d30wk96QCEQH0EgXAc5YhdujY BJqZuWZDPq8hrx7tkgbFrnzaf8xnxpBSxf90un4c+YVq7EPgv/wqfMKY01tlySQdk9NZ1o POOUVR7FsKfEQ0+0fSYNotZWoJ4drUo8rvxArmXDrkzjf8sH5QWoN8W6L0IP/glulrguKf rbGdaM6EbgwpRnQUqmLrVLW1qTHw2jX6WWTXkk2qDYobnSHokTmikfnWKrrvnT+jjDd+Lu 05JoffxgGneVWD89lY+4/gBrn5CObWXQUp26yJvbDb2PF7vGqx7Fn7Z/zPBPMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=oVHna8bP; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685691886; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hVbklZtX0dFu529lr8hEsvy1tw0qVIUh2tOU1E6MpeY=; b=oPrS7KrYZaQSVc72tKhYsBXElX4mF6MTW8hknhhmhlZEwVAdWgKd5e4y5LlhYySnBsys7o SkLiJYgO84p64kFsdu4FNT1oXkWgQEcoJEZkItaKAjyWAP29UBU7o04aoLNizioOF6vtP1 CIWz7cTCDjIfv7GANN00mYpRr41Wqqi/M7F9g3DAyam9/pp95fKhZYOWU9Ix/SxNoSmLvO HFyGFbPcUzuXy1qIeFnAQsLoaPTQqdkI1+YOMD6LkZy6mev2d2VJ148NwkzVMRaB0k4160 FEjlvWm1zUP+p+yiEDU1bIOROTA5WnJMGmc/w1hjOdt4BJ7K4pAoSEAc282f5A== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=oVHna8bP; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -6.43 X-Spam-Score: -6.43 X-Migadu-Queue-Id: 1DF88E7C7 X-TUID: zvFUHORpZGR2 Steven Allen writes: > * lisp/org.el (org-display-inline-images): inline display of attached > images in link descriptions. > > Previously, `org-display-inline-images' only inlined images in link > descriptions when they were explicit "file:" links. This change adds > support for "attachment:" links. E.g.: > > [[https://orgmode.org][attachment:emacs-screenshot.png]] Thanks for the patch, but it does not actually make Org display the example link from the commit message. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at