From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id GN5XB4r5w2ZyDgAAqHPOHw:P1 (envelope-from ) for ; Tue, 20 Aug 2024 02:03:54 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id GN5XB4r5w2ZyDgAAqHPOHw (envelope-from ) for ; Tue, 20 Aug 2024 04:03:54 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GI4f2xdp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1724119434; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CIgngAIRXGzsk17ox+cMxjvGYVHTZ2QDl2Ucso5enWo=; b=BrZePNzLjvK6Z1KNfDxXMlUXXOU3FTrl0TRUSfWyy2rF8ta7BTu6Ikee8B/WaaShGWXRsY +j++IrqbJ95562moW6T3JXoqWqrh6khFaOtlUk3+8vCi0X39RnCItRQwSZpxcZalzwKE3B C2biI7DD51bkVGRxBkXYvn9op16pC4PQhRE3jOMDEmqhBesyfqciPeAPAvFMwQExDdrpGU Y0lEodYLzl0l8kavGUcQ7+JTSSRFon9sQdwY5z/1r88ZIMOhgfS/iGP4zgVcF9AwAhSACy uA6qCAlnxJl3zeCl5Z4f7XfxIleaf6MtYd+RWY75PMQ/+6QKQfYktatmoqcGmQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1724119434; a=rsa-sha256; cv=none; b=nA/esauKEanhMcHjzjdubaCT+TBw3xKrQkqG6FwIedx4qO4mURc7i0Tpsw3hfa30y4yc/m pWbjpsOqmc8ynCG8Abb3hLu3Hqx2k2d384K0gRE48VMHHdoKQ9twxFuFSmx2ix7CBogHQm JNn9OvCeizLFCwekmBgrB5GexthtOhh1tRZkLnUEJzvDT2Bnbh4kycBBkUfOu75VeFyK+R ahoOVnkoUJNhEjK6RPrt31w3NY4K84Rymc1fcWvqtItEXKnplzsUAWfsZnYpZvWIXQF5bM Og+v7qdUOulLDf6Pv6n3aAfk0Jgu+InhJ9heHCNXZgOojkBZfcPUqDtkwtQm6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GI4f2xdp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E6445136EC for ; Tue, 20 Aug 2024 04:03:53 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgECp-0004EH-5w; Mon, 19 Aug 2024 22:02:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgECn-0004E7-TA for emacs-orgmode@gnu.org; Mon, 19 Aug 2024 22:02:41 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgECl-0007ag-VL for emacs-orgmode@gnu.org; Mon, 19 Aug 2024 22:02:41 -0400 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-2020ac89cabso26971305ad.1 for ; Mon, 19 Aug 2024 19:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724119358; x=1724724158; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=CIgngAIRXGzsk17ox+cMxjvGYVHTZ2QDl2Ucso5enWo=; b=GI4f2xdpSfRIhZmDDqm7ihMvph/Gue+HhQxXT6bMzn2OiI/RP189nyEazCCKpfK8PD /k2/nRVw36KxIlXqNH4Y5De4BbhqSs2BNdrwWxKwaeWOT6IA7g9x9EEgxwjHdmCKNh39 FHQVxo4tC34oSHdYb46UogsCEKV8ity+zTN1kwXcN6dyY7WH3JTfngjaYJBQwdlsxvA0 c1a4L4maJDnJHGNQhd20lYz7oz1/4I3TezGi5sO6XBeq+284qq6BixxMUr8k16EZRu+C y7c6IUu7laQtwzS8Hfk9F+DELHa/4jWWJXhtsUNpOmS6M6aaa4dNoUCImAib3YCp5603 edew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724119358; x=1724724158; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CIgngAIRXGzsk17ox+cMxjvGYVHTZ2QDl2Ucso5enWo=; b=OnfcN2frCXpjFMvidMHYveA923p7PpIRr0DZ/sp9eqVUeAazWqKg1vJG5DWke0Qxpu 5DtozLXqMdvGhjcyKvwJJMxIY0x8n8HBAInA1+mnV+6QX0dUyhJDX0WSznxCA40TOhc6 tHLCeZbL8qQNK3aXrl2NcBAnMihLez3hSV6+6tZBsjyzHV+w3rcQCwocK2rH7kc81v1X LMx5C3hyozlkKcgYqE3CXVLcjXnx/vANSEsADx+niboJe0St/DbHAofz3+6gdiP8+yxA 5zMVQeBxWRJmxKhyb1/cC+sQWV2U9z23jVohDodtYP0oVjUJWaQv2OKR3738Q6uwD6ZP zg2w== X-Gm-Message-State: AOJu0YyKutHEHaFC2lfIzQyMmMD2bHGaAY2t3UvMp05tVFjDyPkKIfqg e5AfzkYMsMr8EobT+hBcEgBOQQoMtCQjs0Hz7JsPG9QiZR3a/aMsjEewJQ== X-Google-Smtp-Source: AGHT+IHEacd18wFXvxgBsKZLfHh6Km01CLTqZM4g+msKaUFNTIrsHB4bpvbGB29eXpKSm5qX6UZpmg== X-Received: by 2002:a17:902:da8a:b0:1fd:9a23:90cc with SMTP id d9443c01a7336-20203eb1b81mr129214415ad.26.1724119357492; Mon, 19 Aug 2024 19:02:37 -0700 (PDT) Received: from localhost ([2600:8802:5726:2500:6397:ffac:bfd9:3937]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201f03a34c5sm68241605ad.280.2024.08.19.19.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 19:02:36 -0700 (PDT) From: Karthik Chikmagalur To: Ihor Radchenko , stardiviner Cc: Org mode Subject: Re: [PATCH v4.0] Re: [PATCH] add a function to only refresh inline images under current headline instead of global buffer In-Reply-To: <87v7zyyvm3.fsf@localhost> References: <6461a84b.a70a0220.b6d36.5d00@mx.google.com> <87sfbxhmxe.fsf@localhost> <64623c09.170a0220.52bf9.9437@mx.google.com> <87y1lo4ou1.fsf@localhost> <646379fc.620a0220.c0ae4.9fb2@mx.google.com> <87zg3l1rgb.fsf@localhost> <64c8a313.a70a0220.93ee0.14fb@mx.google.com> <87il9zgpdp.fsf@localhost> <64c905d7.170a0220.f434a.fddb@mx.google.com> <87o7jpoqfl.fsf@localhost> <64cc9b8a.170a0220.dfa99.2e18@mx.google.com> <87msz7kym0.fsf@localhost> <669882e5.050a0220.8ff6d.33c6@mx.google.com> <871q3logb9.fsf@localhost> <66a8b73b.170a0220.383476.996e@mx.google.com> <87o75yhwnu.fsf@localhost> <87v7zyyvm3.fsf@localhost> Date: Mon, 19 Aug 2024 19:02:35 -0700 Message-ID: <87frr07xz8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=karthikchikmagalur@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: E6445136EC X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.79 X-Spam-Score: -9.79 X-TUID: KehOM8PMSOsI > stardiviner writes: > >> I agree with your patch solution. I have tested fine. Thanks for your >> re-write. > > Applied, onto main. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d51dc4aa29 I just noticed this change, and had a couple of suggestions. Right now the commands org-latex-preview and org-toggle-inline-images-command do similar things -- placing overlays over LaTeX fragments or image links respectively. But their regular and prefix arg behaviors are different: | Calling convention | org-latex-preview | org-toggle-inline-images-command | |--------------------+-------------------------------+-----------------------------------| | C-c C-x C-[l,v] | toggle preview at point | toggle preview at point | | | or preview current entry | or toggle in current entry | | With C-u | Clear previews in section | Toggle previews in whole buffer | | With C-u C-u | Preview whole buffer | Hide all previews in whole buffer | | With C-u C-u C-u | Hide previews in whole buffer | - | I think this is confusing, and it will help to stick to a single convention for previewing "things" in Org. Of the two, I prefer org-latex-preview's behavior and have been using a custom library [1] to toggle images this way, but so long as it is consistent I would be okay with either set of behaviors. Karthik [1]: https://github.com/karthink/org-image-preview