emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: John Wiegley <johnw@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch to add a new org-archive hook and context info type
Date: Mon, 23 Dec 2024 17:36:51 +0000	[thread overview]
Message-ID: <87frmejo7g.fsf@localhost> (raw)
In-Reply-To: <m2ttcja7md.fsf@gnu.org>

"John Wiegley" <johnw@gnu.org> writes:

> The following patch adds ‘org-archive-finalize-hook’, which runs earlier than
> ‘org-archive-hook’ and in the destination buffer, not the original file. This
> allows the context to be extended, the archived entry to be cleaned up after
> inseration, maybe even encrypted or hashed to prevent changes.
>
> I also added a new ‘ARCHIVE_OLID’ context type, which preserves the ID of the
> parent the archived entry was previously under. This is because ARCHIVE_OLPATH
> is not stable: it’s very possible the tree structure may change over time and
> invalidate the path. But as long as the original parent is not deleted, there
> stands a better chance that the original context of the archived entry can be
> restored.

Thanks!
May you please split the patch into multiple - one per feature, document
the new features in etc/ORG-NEWS, and add a proper commit message to the
patches?

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      parent reply	other threads:[~2024-12-23 17:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07  6:19 Patch to add a new org-archive hook and context info type John Wiegley
2024-11-23 16:45 ` Problem installing Org using the Emacs packaging system Alain.Cochard
2024-12-16 19:08   ` Ihor Radchenko
2024-12-22  3:07     ` Alain.Cochard
2024-12-22  9:19       ` Ihor Radchenko
2024-12-22 13:02         ` Alain.Cochard
2024-12-23 16:16     ` Ihor Radchenko
2024-12-18  3:24 ` Patch to add a new org-archive hook and context info type Liu Hui
2024-12-23 17:36 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frmejo7g.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=johnw@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).