From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Jackson Subject: Re: org-bookmark.el Date: Thu, 28 Feb 2008 16:02:34 +0000 Message-ID: <87ejaxhxwl.fsf@shellarchive.co.uk> References: <87ir0ajrol.fsf@bzg.ath.cx> <87fxvdi0kq.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUlDX-0001jI-Fw for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 11:02:43 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUlDV-0001iy-CG for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 11:02:42 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUlDV-0001iv-9Q for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 11:02:41 -0500 Received: from c.painless.aaisp.net.uk ([81.187.30.53]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JUlDV-0006Wq-1W for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 11:02:41 -0500 In-Reply-To: <87fxvdi0kq.fsf@bzg.ath.cx> (Bastien's message of "Thu, 28 Feb 2008 15:04:53 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Tokuya Kameshima , emacs-orgmode@gnu.org Bastien writes: > In any case, this should be implemented in org.el directly. When > `org-store-link' checks whether we are in dired-mode or in a buffer > visiting a file, then it would also check whether 'org-bookmark is > provided (with (featurep 'org-bookmark)...) and act accordingly if it > is. I don't think it needs to go into org.el does it? When org-bookmark gets it's turn upon `org-store-link' it should check a variable called, for example, `org-bookmark-check-bookmarks-first' and then if that's non-nil check major-mode and act accordingly. This will keep `org-store-link' nice and clean. Cheers, Phil -- Phil Jackson http://www.shellarchive.co.uk