From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Rose Subject: Re: Export ascii-images using ditaa when targeting HTML? Date: Wed, 12 Nov 2008 22:54:42 +0100 Message-ID: <87ej1g4nkt.fsf@kassiopeya.MSHEIMNETZ> References: <878wrpso07.fsf@gmail.com> <874p2dgid4.fsf@kassiopeya.MSHEIMNETZ> <1BA2B74F-75F6-4176-A3D3-7CCD672B7520@uva.nl> <874p2c6bgk.fsf@kassiopeya.MSHEIMNETZ> <87zlk4hj2a.fsf@gmail.com> <87vdus4v1g.fsf@kassiopeya.MSHEIMNETZ> <873ahwhhcc.fsf@gmail.com> <87myg44rfk.fsf@kassiopeya.MSHEIMNETZ> <87ej1geknp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0NdA-0001yX-Hz for emacs-orgmode@gnu.org; Wed, 12 Nov 2008 16:52:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0Nd7-0001wo-Bq for emacs-orgmode@gnu.org; Wed, 12 Nov 2008 16:52:07 -0500 Received: from [199.232.76.173] (port=58691 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0Nd6-0001wh-Ql for emacs-orgmode@gnu.org; Wed, 12 Nov 2008 16:52:04 -0500 Received: from mail.gmx.net ([213.165.64.20]:35154) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1L0Nd6-0002bE-3e for emacs-orgmode@gnu.org; Wed, 12 Nov 2008 16:52:04 -0500 In-Reply-To: <87ej1geknp.fsf@gmail.com> (Eric Schulte's message of "Wed, 12 Nov 2008 12:47:38 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi Eric, yes, this looks fine to me and works :-) What do the others think? I believe overwriting is the desired behaviour on export. I use org-publish-attachment for images, stylesheets, scripts and so on. And they shurely should be updated in the publishing-directory. I just wonder, why I never ran into that problem. All the other files where always overwritten. One more: If I refile an entry containing such an ditaa image, the old image remains in both, the base-directory, and the publishing-directory. An option to set the image directory relative to base-directory (and adjust the link accordingly) would be very nice. That way, we could refer to the image in other files too and the links would work after refiling such an entry. Thanks again, Sebastian "Eric Schulte" writes: > Sebastian Rose writes: > >> Hi Eric, >> >> >> sorry for being unclear. I use the -o option. The image is always >> created correctly. But it seems that the exporter >> (org-publish-attachment) refuses to overwrite existing files. >> > > Hi Sebastian, > > I see now. It looks like org-publish-attachment uses the `copy-file' > function to copy files to the publish directory. We just need to set an > option argument to copy-file to tell it how to deal with overwriting. > > ,----[from copy-file documentation] > | The optional third argument OK-IF-ALREADY-EXISTS specifies what to do > | if file NEWNAME already exists. If OK-IF-ALREADY-EXISTS is nil, we > | signal a `file-already-exists' error without overwriting. If > | OK-IF-ALREADY-EXISTS is a number, we request confirmation from the user > | about overwriting; this is what happens in interactive use with M-x. > | Any other value for OK-IF-ALREADY-EXISTS means to overwrite the > | existing file. > `---- > > This file is currently set to nil, we should probably set it to t so it > always overwrites files. Does that sound like the best option? > > The attached minimal patch set this option to t. > > Best -- Eric > > > diff --git a/lisp/org-publish.el b/lisp/org-publish.el > index aa8c495..bbd9180 100644 > --- a/lisp/org-publish.el > +++ b/lisp/org-publish.el > @@ -537,7 +537,7 @@ See `org-publish-org-to' to the list of arguments." > ;; make sure eshell/cp code is loaded > (unless (file-directory-p pub-dir) > (make-directory pub-dir t)) > - (copy-file filename pub-dir)) > + (copy-file filename pub-dir t)) > > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > ;;; Publishing files, sets of files, and indices > -- Sebastian Rose, EMMA STIL - mediendesign, Niemeyerstr.6, 30449 Hannover Tel.: +49 (0)511 - 36 58 472 Fax: +49 (0)1805 - 233633 - 11044 mobil: +49 (0)173 - 83 93 417 Email: s.rose emma-stil de, sebastian_rose gmx de Http: www.emma-stil.de