From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: [babel][PATCH][tests] ERT as external library deprecated. Date: Wed, 02 Mar 2011 11:42:48 -0700 Message-ID: <87ei6ptl4o.fsf@gmail.com> References: <87pqqb2k5t.fsf@btinternet.com> <87aahe68n7.fsf@gmail.com> <87fwr5mshb.fsf@norang.ca> <874o7lea4e.fsf@btinternet.com> <87zkpdv4qz.fsf@gmail.com> <87oc5tqsqz.fsf_-_@btinternet.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from [140.186.70.92] (port=49019 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pur5N-0000uR-5b for emacs-orgmode@gnu.org; Wed, 02 Mar 2011 13:47:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pur5L-0004Gh-EW for emacs-orgmode@gnu.org; Wed, 02 Mar 2011 13:47:44 -0500 Received: from mail-px0-f169.google.com ([209.85.212.169]:56050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pur5L-0004GP-3X for emacs-orgmode@gnu.org; Wed, 02 Mar 2011 13:47:43 -0500 Received: by pxi9 with SMTP id 9so46831pxi.0 for ; Wed, 02 Mar 2011 10:47:42 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Martyn Jago Cc: emacs-orgmode@gnu.org Applied, Thanks -- Eric Martyn Jago writes: > "Eric Schulte" writes: > > Hi Eric > > Here is a patch for the new testing/README.org and several new > tests. Perhaps I should tag test patches [tests] to point out that the > commit contains no code that can break the build (only potentially the > tests)? > up to you... > > Regards > > Martyn > > > > --- > Org-mode version 7.4 (release_7.4.581.g84dfb) > GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.0) > of 2011-02-25 > >> Martyn Jago writes: >> >>> Bernt Hansen writes: >>> >>> Hi Bernt >>> >>> No problem at all using older Emacsen. There is a dependency however for >>> a recent version of the ERT library since some name changes occurred in >>> preparation for becoming EMACS. I'll add a note to testing/README.org >>> including a relevant link. >>> >> >> The testing/ert directory is ignored by git so you can install ert there >> without conflicting with the org-mode repository. >> >> Best -- Eric >> >>> >>> Regards >>> >>> Martyn >>> >>>> Hi Eric and Martyn, >>>> >>>> "Eric Schulte" writes: >>>> >>>>> Hi Martyn, >>>>> >>>>> Thanks for the patch, I have just applied it. >>>>> >>>>> Best -- Eric >>>>> >>>>> Martyn Jago writes: >>>>> >>>>>> Hi >>>>>> >>>>>> The ERT library is now a part of EMACS. As a result the ERT library >>>>>> files currently loaded as a sub-module have been deleted on Github. >>>>>> >>>>>> This change modifies .gitmodule to avoid attempting to load ERT. >>>>>> Changes have been made to testing/README.org to suit. >>>>>> >>>>>> An insertion has been made to testing/README.org to point out that the >>>>>> library-of-babel.org file needs ingesting (including a source block to >>>>>> do so) to enable some tests to pass, and the "ERT reference" now points >>>>>> to the included ERT info help pages. >>>>>> >>>>>> Broken dependencies in testing/org-test.el have been removed. >>>>>> >>>>>> I have also temporarily commented out a small number of broken tests >>>>>> which between them cause ERT to go off into the weeds and delete a large >>>>>> section of babel.org. This means that all tests currently pass. >>>>>> >>>>>> I will investigate the breakages and hopefully provide fixes. >>>>>> >>>>>> Hope this helps >>>> >>>> Does this change still allow older Emacsen to use the testing library? >>>> I have >>>> >>>> GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) >>>> of 2010-12-11 on raven, modified by Debian >>>> >>>> and I would still like to be able to run the test suite without >>>> requiring an upgrade to Emacs 24. >>>> >>>> Attempting to load the test library in my Emacs now gives the following >>>> error: >>>> >>>> Loading /home/bernt/git/org-mode/testing/org-test.el (source)... >>>> let*: Cannot open load file: ert-x >>>> >>>> Regards, >>>> Bernt >>>> >>>> >>>> _______________________________________________ >>>> Emacs-orgmode mailing list >>>> Please use `Reply All' to send replies to the list. >>>> Emacs-orgmode@gnu.org >>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode >>> >>> >>> _______________________________________________ >>> Emacs-orgmode mailing list >>> Please use `Reply All' to send replies to the list. >>> Emacs-orgmode@gnu.org >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode -- Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode