From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Org release 7.8.07 (BUGFIX-only release) Date: Sun, 01 Apr 2012 10:37:00 +0200 Message-ID: <87ehs7hmqb.fsf@gnu.org> References: <87ty15ulqc.fsf@altern.org> <87ehs8kir5.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:53859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEGGL-0004Fn-87 for emacs-orgmode@gnu.org; Sun, 01 Apr 2012 04:35:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEGGI-0002dA-JU for emacs-orgmode@gnu.org; Sun, 01 Apr 2012 04:35:48 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:56240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEGGI-0002d4-9T for emacs-orgmode@gnu.org; Sun, 01 Apr 2012 04:35:46 -0400 Received: by wgbdr1 with SMTP id dr1so1310044wgb.30 for ; Sun, 01 Apr 2012 01:35:44 -0700 (PDT) In-Reply-To: <87ehs8kir5.fsf@Rainer.invalid> (Achim Gratz's message of "Sat, 31 Mar 2012 15:22:22 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Hi Achim, Achim Gratz writes: > Bastien writes: >> This is the version that will be merged into Emacs' trunk >> by tomorrow. > > Please tag the release on maint so that Git reports the correct > version. Done. (I tagged locally but forgot to push the tag.) >> Please report critical bugs using "URGENT" >> in the subject line. > > All tests (except for R which I can't run due to lack of ESS) are clean > on openSUSE/Tumbleweed with both Emacs 23.4 and 24.0.94. Yes. >> Thanks all for your help! > > I'm still getting these complaints about unprefixed / global variables > w/ latest Emacs24 from trunk and fresh pull from master: > > In toplevel form: > org.el:4871:1:Warning: global/dynamic var `date' lacks a prefix > > In toplevel form: > org-agenda.el:95:1:Warning: global/dynamic var `date' lacks a prefix > > In toplevel form: > org-bbdb.el:122:1:Warning: global/dynamic var `date' lacks a prefix > org-bbdb.el:123:1:Warning: global/dynamic var `name' lacks a prefix The problem with the `name' global variable is not in maint, I will have a look in master. > In toplevel form: > org-remember.el:280:1:Warning: global/dynamic var `annotation' lacks a prefix > org-remember.el:281:1:Warning: global/dynamic var `initial' lacks a prefix Yes, I know. This is not easy to fix, because the ̀€date' global variable is set from calendar. Same for annotation and initial, which are set from remember.el. If you see a place where the fix is trivial (i.e. where my assumption is false), please submit it. > There is something going on in org-compat that I don't understand at all > (note that find-library is not called at that poit at all, so there must > be some macro expansion at work). This is also in Emacs23: > > In org-find-library-name: > org-compat.el:341:14:Warning: find-library called with 3 arguments, but > accepts only 1 Well, this is the culprit compatibility defun: (defun org-find-library-name (library) (if (fboundp 'find-library-name) (file-name-directory (find-library-name library)) ; XEmacs does not have `find-library-name' (flet ((find-library-name-helper (filename ignored-codesys) filename) (find-library-name (library) (find-library library nil 'find-library-name-helper))) <<<<< (file-name-directory (find-library-name library))))) I don't know how to circumvent this warning and btw I don't have this warning in Emacs 24.0.94.1. > Lastly, there's a function that has been obsoleted with Emacs24, so it > should probably get a shim in org-compat to refer to one or the other > definition based on Emacs version in a with-no-error form. > > In org-indent-mode: > org-indent.el:212:11:Warning: `buffer-substring-filters' is an obsolete > variable (as of 24.1); use `filter-buffer-substring-functions' instead. > org-indent.el:213:12:Warning: `buffer-substring-filters' is an obsolete > variable (as of 24.1); use `filter-buffer-substring-functions' instead. > org-indent.el:213:12:Warning: `buffer-substring-filters' is an obsolete > variable (as of 24.1); use `filter-buffer-substring-functions' instead. Yes. The fix is not trivial. Patch welcome! Thanks, -- Bastien