From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Schulte <eric.schulte@gmx.com>
Subject: Re: Org Build System (aka Makefile)
Date: Mon, 13 Aug 2012 16:43:42 -0600
Message-ID: <87ehna8lb5.fsf@gmx.com>
References: <87y5mkrca2.fsf@Rainer.invalid> <87ipcs3smd.fsf@Rainer.invalid>
	<871ujf5i7g.fsf@gnu.org> <874no8dxik.fsf@Rainer.invalid>
	<87k3x4rlb2.fsf@gmx.com> <87zk5zdery.fsf@Rainer.invalid>
	<87boifrkyl.fsf@gmx.com> <874no6zz0v.fsf@gnu.org>
	<877gt2oami.fsf@Rainer.invalid>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:55129)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.schulte@gmx.com>) id 1T13Q2-00033a-23
	for emacs-orgmode@gnu.org; Mon, 13 Aug 2012 18:47:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.schulte@gmx.com>) id 1T13Q0-0006aA-H6
	for emacs-orgmode@gnu.org; Mon, 13 Aug 2012 18:47:29 -0400
Received: from mailout-us.gmx.com ([74.208.5.67]:50482)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <eric.schulte@gmx.com>) id 1T13Q0-0006a5-AL
	for emacs-orgmode@gnu.org; Mon, 13 Aug 2012 18:47:28 -0400
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Achim Gratz <Stromeko@nexgo.de> writes:

> Bastien writes:
>> However, I would suggest these changes to the current default.mk:
>
> These changes do not belong into default.mk =E2=80=94 default.mk is the f=
allback
> for when no changes to local.mk have been made.
>
>> - Have a target `make single' (useful for developers)
>>
>> - `make elint' would run the current `make _COMPILE_=3Dslint3'.
>
> I don't like such proliferation of toplevel targets since they can't be
> overridden by users,

I second the idea that a top level 'make elint' would be very useful for
developers (see the attached patch).  In my opinion this would be more
useful than a number of existing top-level targets, e.g., config-*,
update, update2, cleanall, cleandirs, cleancontrib, cleantesting,
cleanutils, cleanelc and targets.

So if we want to have fewer top level targets (which I think would also
be a good idea), perhaps one or more of the above could be removed
before an elint target is added.

> things like this (an alias) are easy enough to set up in local.mk:

But many more people will use such a target if it exists at the top
level and is mentioned by "make help".


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
 filename=0001-adding-elint-top-level-Makefile-target.patch

>From 39e1ce6e8f33561db94451248d1c17705bd8f4ee Mon Sep 17 00:00:00 2001
From: Eric Schulte <eric.schulte@gmx.com>
Date: Mon, 13 Aug 2012 16:42:59 -0600
Subject: [PATCH] adding elint top-level Makefile target

---
 Makefile   | 1 +
 targets.mk | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/Makefile b/Makefile
index 71e2765..0b9535e 100644
--- a/Makefile
+++ b/Makefile
@@ -29,6 +29,7 @@ help helpall::
 	$(info make compile        - build Org ELisp files)
 	$(info make autoloads      - create org-install.el to load Org in-place)
 	$(info make check          - build Org ELisp files and run test suite)
+	$(info make elint          - perform a static check of ELisp source files)
 helpall::
 	$(info make test           - ditto)
 	$(info make compile-dirty  - build only stale Org ELisp files)
diff --git a/targets.mk b/targets.mk
index 29b0aa5..7ddaff1 100644
--- a/targets.mk
+++ b/targets.mk
@@ -80,6 +80,9 @@ compile compile-dirty::
 all clean-install::
 	$(foreach dir, $(SUBDIRS), $(MAKE) -C $(dir) $@;)
 
+elint:
+	$(MAKE) -b _COMPILE_=slint3
+
 check test::	compile
 check test test-dirty::
 	-$(MKDIR) $(testdir)
-- 
1.7.11.4


--=-=-=
Content-Type: text/plain


-- 
Eric Schulte
http://cs.unm.edu/~eschulte

--=-=-=--