Re: [PATCH (new version)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language.

[Rasmus <rasmus@gmx.us>]

Nicolas Goaziou <n.goaziou@gmail.com> writes:

>> It changes behavior for your setup in that you can define a LANGUAGE
>> that isn't a known abbreviation.
>
> While I think your patch is overall an improvement, I'm not convinced by
> this particular point. Indeed #+LANGUAGE: expects a language code as
> value, not just any string. This is important since latex backend is not
> the only one to use that keyword.

We can discard this, of course.  

> For example, imagine a user in need for german smart quotes. How do you
> explain to him than #+language: german will not work, but #+language: de
> will?

A combination of `org-latex-babel-language-alist' and 'look at the
output' and feeble explanations of translations :)

How do we explain that to use his favorite babel, perhaps his own
"germanme", is not available extending org-latex-babel-language-alist?
Of course, in this case it's just a matter of using a LATEX_HEADER, so
it's not worth arguing about, and I'm happy to remove it.

> I think special Babel needs can be handled elsewhere.

Was this related to the above?

> You need to punctuate your sentence.

OK.

>> +		       (remove "AUTO"
>
> You can use `delete' instead of `remove': no need to copy the list.

Thanks.

> There cannot be any "\n" in the value, so you can use "[ \t]+" instead.
> Also, you don't need the `replace-regexp-in-string' part:
>   (org-split-string (match-string 1 header) ",[ \t]*")

I didn't know it was a repexp, thanks!

> The problem with this implementation is that it will not put LANGUAGE at
> the same place AUTO was. IOW, there's no difference between:
>
>   #+LATEX_HEADER: \usepackage[AUTO,danish]{babel}
>
> and,
>
>   #+LATEX_HEADER: \usepackage[danish,AUTO]{babel}
>
> although it matters in LaTeX.

Sure that's wasn't part of the 'deal', but I can see how it would
matter, and it makes more sense in this way.

I'll see if I can fix these bugs.  Thanks for the feedback.

–Rasmus

-- 
Powered by magic pixies!