bug#15887: Possibly incorrect custom :types

bug#15887: Possibly incorrect custom :types

[Glenn Morris]

Package: org-mode

cus-test.el suggests the following variables may have incorrect
custom :types. (There may be some false positives.)
This refers to Org mode in current Emacs trunk.

Eg, org-texinfo-filename does not have "nil" as an option.

org-agenda-deadline-leaders
org-agenda-search-view-max-outline-level
org-ascii-format-drawer-function
org-ascii-format-inlinetask-function
org-babel-latex-htlatex
org-babel-latex-htlatex-packages
org-babel-lob-files
org-babel-python-None-to
org-babel-python-mode
org-babel-ruby-nil-to
org-export-async-init-file
org-export-with-creator
org-html-format-drawer-function
org-html-format-headline-function
org-html-format-inlinetask-function
org-html-with-latex
org-latex-format-drawer-function
org-latex-format-inlinetask-function
org-log-note-headings
org-mouse-1-follows-link
org-odt-format-drawer-function
org-odt-format-headline-function
org-odt-format-inlinetask-function
org-odt-with-latex
org-plantuml-jar-path
org-texinfo-filename
org-texinfo-format-drawer-function
org-texinfo-format-headline-function
org-texinfo-format-inlinetask-function
orgstruct-heading-prefix-regexp

bug#15887: Possibly incorrect custom :types

[Bastien]

Glenn Morris <rgm@gnu.org> writes:

> Package: org-mode
>
> cus-test.el suggests the following variables may have incorrect
> custom :types. (There may be some false positives.)
> This refers to Org mode in current Emacs trunk.
>
> Eg, org-texinfo-filename does not have "nil" as an option.
>
> org-agenda-deadline-leaders
> org-agenda-search-view-max-outline-level
> org-ascii-format-drawer-function
> org-ascii-format-inlinetask-function
> org-babel-latex-htlatex
> org-babel-latex-htlatex-packages
> org-babel-lob-files
> org-babel-python-None-to
> org-babel-python-mode
> org-babel-ruby-nil-to
> org-export-async-init-file
> org-export-with-creator
> org-html-format-drawer-function
> org-html-format-headline-function
> org-html-format-inlinetask-function
> org-html-with-latex
> org-latex-format-drawer-function
> org-latex-format-inlinetask-function
> org-log-note-headings
> org-mouse-1-follows-link
> org-odt-format-drawer-function
> org-odt-format-headline-function
> org-odt-format-inlinetask-function
> org-odt-with-latex
> org-plantuml-jar-path
> org-texinfo-filename
> org-texinfo-format-drawer-function
> org-texinfo-format-headline-function
> org-texinfo-format-inlinetask-function
> orgstruct-heading-prefix-regexp

I fixed those problems in Org's maintainance branch, this will be part
of the next merge.  Thanks!

-- 
 Bastien

bug#15887: Possibly incorrect custom :types

[Glenn Morris]

I glanced at the diff. I'm not sure the :set changes are correct.
Won't this make it impossible to customize these options?
Those cases may have been some of the false positives I mentioned.
Eg

(if (or (featurep 'xemacs) (featurep 'python-mode)) 'python-mode 'python)

is fine for :type 'function, but cus-test is simple-minded and
doesn't realize that the result of the expression will always be a
function, so it gives a bogus warning.

bug#15887: Possibly incorrect custom :types

[Bastien]

Hi Glenn,

Glenn Morris <rgm@gnu.org> writes:

> I glanced at the diff. I'm not sure the :set changes are correct.
> Won't this make it impossible to customize these options?
> Those cases may have been some of the false positives I mentioned.
> Eg
>
> (if (or (featurep 'xemacs) (featurep 'python-mode)) 'python-mode 'python)
>
> is fine for :type 'function, but cus-test is simple-minded and
> doesn't realize that the result of the expression will always be a
> function, so it gives a bogus warning.

Thanks for pointing this, I misunderstood the purpose of :set.
This is fixed in the maint branch.

-- 
 Bastien