From mboxrd@z Thu Jan  1 00:00:00 1970
From: Achim Gratz <Stromeko@nexgo.de>
Subject: [Bug] commit 39070b7fc7 breaks babel test
Date: Wed, 27 Nov 2013 08:58:59 +0100
Message-ID: <87eh622s3g.fsf@Rainer.invalid>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53158)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Vla1n-0002pE-Oz
	for emacs-orgmode@gnu.org; Wed, 27 Nov 2013 02:59:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Vla1h-0000Sr-K9
	for emacs-orgmode@gnu.org; Wed, 27 Nov 2013 02:59:19 -0500
Received: from plane.gmane.org ([80.91.229.3]:47440)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Vla1h-0000Rj-DF
	for emacs-orgmode@gnu.org; Wed, 27 Nov 2013 02:59:13 -0500
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Vla1e-0007PY-6J
	for emacs-orgmode@gnu.org; Wed, 27 Nov 2013 08:59:10 +0100
Received: from pd9eb15ab.dip0.t-ipconnect.de ([217.235.21.171])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Wed, 27 Nov 2013 08:59:10 +0100
Received: from Stromeko by pd9eb15ab.dip0.t-ipconnect.de with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Wed, 27 Nov 2013 08:59:10 +0100
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Hi Eric,

this change seems to introduce additional line breaks in the following
test:

--8<---------------cut here---------------start------------->8---
Test test-ob/catches-all-references condition:
    (ert-test-failed
     ((should
       (string=
        (org-babel-execute-src-block)
        "A literal example\non two lines for me."))
      :form
      (string= "A literal example\non two lines\n for me." "A literal example\non two lines for me.")
      :value nil))
   FAILED  1/1  test-ob/catches-all-references
--8<---------------cut here---------------end--------------->8---

This seems to happen because the final \n from the babel result is not
stripped anymore, pointing to the change in ob-core.  IIRC we
flip-flopped a few times already with including or not including this
final newline, so I don't know whether the code or the test should
change.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds