From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Ecay <aaronecay@gmail.com>
Subject: Re: [PATCH] -for review- Tangling with variable transfer of
 variables
Date: Sat, 21 Jun 2014 23:39:09 -0400
Message-ID: <87egyhboki.fsf@gmail.com>
References: <m2ha3g8xei.fsf@krugs.de> <87zjh8bo8s.fsf@gmail.com>
	<loom.20140620T002034-706@post.gmane.org>
	<m2vbrv7mdo.fsf@krugs.de> <m2r42jnwvu.fsf@krugs.de>
	<alpine.OSX.2.00.1406211148460.344@charles-berrys-macbook.local>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35774)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1WyYck-0007CA-3m
	for emacs-orgmode@gnu.org; Sat, 21 Jun 2014 23:39:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1WyYcb-00045z-35
	for emacs-orgmode@gnu.org; Sat, 21 Jun 2014 23:39:22 -0400
Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:57282)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1WyYca-00045q-Tk
	for emacs-orgmode@gnu.org; Sat, 21 Jun 2014 23:39:13 -0400
Received: by mail-qc0-f178.google.com with SMTP id c9so4877864qcz.23
	for <emacs-orgmode@gnu.org>; Sat, 21 Jun 2014 20:39:12 -0700 (PDT)
In-Reply-To: <alpine.OSX.2.00.1406211148460.344@charles-berrys-macbook.local>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: "Charles C. Berry" <ccberry@ucsd.edu>, Rainer M Krug <Rainer@krugs.de>
Cc: emacs-orgmode@gnu.org, Eric Schulte <schulte.eric@gmail.com>

Hi Rainer,

2014ko ekainak 21an, "Charles C. Berry"-ek idatzi zuen:
> 
> On Fri, 20 Jun 2014, Rainer M Krug wrote:
> 
>> Attached please find =the reworked patch.
>> 
>> 1) uses local() and closes connection
>> 2) does not leave a variable cal;led file behind
>> 
> 
> Seems to work on a few test cases.
> 
> I'd move the strings to defconsts.
> 
> Putting a newline before each `%S' will outdent the first line of 
> :var value when it is echoed in the session log so it will be easier to 
> view.

+1 to both of the above suggestions but otherwise the patch looks good
and I think it should be applied.

-- 
Aaron Ecay