From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Ecay <aaronecay@gmail.com>
Subject: Re: [RFC] [PATCH] bug with babel call lines and cache
Date: Thu, 05 Nov 2015 15:06:01 +0000
Message-ID: <87egg4v63q.fsf@gmail.com>
References: <87twp8wpx5.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1ZuM75-0003fj-Cf
	for emacs-orgmode@gnu.org; Thu, 05 Nov 2015 10:06:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1ZuM72-00039D-1v
	for emacs-orgmode@gnu.org; Thu, 05 Nov 2015 10:06:07 -0500
Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:35211)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1ZuM71-00038z-PN
	for emacs-orgmode@gnu.org; Thu, 05 Nov 2015 10:06:03 -0500
Received: by wicll6 with SMTP id ll6so11950409wic.0
	for <emacs-orgmode@gnu.org>; Thu, 05 Nov 2015 07:06:03 -0800 (PST)
Received: from localhost (natvip7.york.ac.uk. [144.32.240.7])
	by smtp.gmail.com with ESMTPSA id
	186sm34612301wmp.10.2015.11.05.07.06.02 for <emacs-orgmode@gnu.org>
	(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Thu, 05 Nov 2015 07:06:02 -0800 (PST)
In-Reply-To: <87twp8wpx5.fsf@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Org-mode <emacs-orgmode@gnu.org>

Hello all,

2015ko urriak 30an, Aaron Ecay-ek idatzi zuen:
>=20
> Hello all,
>=20
> In playing around with some of the cache-related issues, I=E2=80=99ve dis=
covered
> that C-c C-c on the following #+call line will give the following
> backtrace:
>=20

[...]

>=20
> The problem is that unprocessed params (in the sense of
> org-babel-process-params) are passed to org-babel-sha1-hash under some
> circumstances.
>=20
> The attached patch fixes this issue by simplifying some code in
> org-babel-execute-src-block.  I=E2=80=99m slightly uncomfortable about it
> because I remember touching the various nested =E2=80=98let=E2=80=99s whi=
ch toggle
> between different states of =E2=80=98params=E2=80=99 in that function onc=
e upon a
> time, and they seemed important.  Now I can=E2=80=99t remember why, thoug=
h.
> So I=E2=80=99d be happier if someone else familiar with babel=E2=80=99s c=
ode looked
> the patch over.
>=20
> If no one pipes up in a few days, I will push the patch and see if
> anything breaks.

Pushed to master as 4750e44 (with a couple cosmetic changes from the
original version).

--=20
Aaron Ecay