From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rasmus <rasmus@gmx.us>
Subject: Re: [patch] get modification-time from vc
Date: Wed, 18 May 2016 21:45:25 +0200
Message-ID: <87eg8zf8ve.fsf@gmx.us>
References: <877ffhn3gz.fsf@gmx.us> <87shy2ydpx.fsf@saiph.selenimh>
	<87k2irad3q.fsf@gmx.us> <8737pfxqlp.fsf@saiph.selenimh>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37296)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1b37PX-0005s9-Fv
	for emacs-orgmode@gnu.org; Wed, 18 May 2016 15:45:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1b37PS-0006Zb-Em
	for emacs-orgmode@gnu.org; Wed, 18 May 2016 15:45:38 -0400
Received: from plane.gmane.org ([80.91.229.3]:43595)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1b37PS-0006ZH-1f
	for emacs-orgmode@gnu.org; Wed, 18 May 2016 15:45:34 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1b37PQ-0003q7-El
	for emacs-orgmode@gnu.org; Wed, 18 May 2016 21:45:32 +0200
Received: from ip-178-203-232-77.hsi10.unitymediagroup.de ([178.203.232.77])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Wed, 18 May 2016 21:45:32 +0200
Received: from rasmus by ip-178-203-232-77.hsi10.unitymediagroup.de with local
	(Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Wed, 18 May 2016 21:45:32 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Hi,

Thanks for the comments!

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Why enforcing "vc" and not any non-nil/non-empty second argument instead ?

No point, really.

>> Is cl-lib OK now?!
>
> cl-lib is OK in master. Minimal requirement for master is Emacs 24.3.

Cool.
>> +		       (when (cl-some 'identity time)
>> +			 (setq date (apply #'encode-time time))))))))
>
> Why #'encode-time and not #'identity ?

To test if you review the all the way to the end!  Or...

> In any case, this looks good. Please push when you're happy with the
> result.

Pushed. 

Rasmus

-- 
And when I’m finished thinking, I have to die a lot