From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Bellani Subject: Re: [PATCH] Fix clocktable scope parameter Date: Thu, 15 Dec 2016 14:04:49 -0200 Message-ID: <87eg19uqji.fsf@gmail.com> References: <8760ml2q30.fsf@gmail.com> <87y3zh5iu0.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHYXi-0005nb-5Z for emacs-orgmode@gnu.org; Thu, 15 Dec 2016 11:06:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHYXd-0000DN-8D for emacs-orgmode@gnu.org; Thu, 15 Dec 2016 11:06:02 -0500 Received: from mail-vk0-f65.google.com ([209.85.213.65]:33561) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cHYXd-0000D8-3m for emacs-orgmode@gnu.org; Thu, 15 Dec 2016 11:05:57 -0500 Received: by mail-vk0-f65.google.com with SMTP id l126so8112328vkh.0 for ; Thu, 15 Dec 2016 08:05:57 -0800 (PST) In-reply-to: <87y3zh5iu0.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Org Mode , Eduardo Bellani --=-=-= Content-Type: text/plain Hello everyone, One extra question, about documentation. The place for documenting this feature seems to be 'orgmanual.org'. But my searches revealed that there is also 'org.texi' there. Exporting the first file to the texi format didn't match the second file. Is there a documentation about, well, adding documentation? Thanks. Nicolas Goaziou writes: > Hello, > > Eduardo Bellani writes: > >> org-clock.el: Fix clocktable scope parameter >> >> * lisp/org-clock.el (org-dblock-write:clocktable): Make sure to eval >> the scope if it is a lisp expression, or to return the scope if it >> is just a list. >> >> This adds back to the clocktable the capacity to have as scope both a >> list of file paths or a function that returns such a list. > > Thank you. > > However, I'd rather not introduce more `eval' in the code base. > > Instead, you can test if scope is a function and `funcall' it. This is > a new feature, which would require some documentation and an entry in > ORG-NEWS. > > Regards, --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlhSvyEACgkQSbLl0kCTjGllRwCfapPx0B30iRPcufC7+jm3C+fS V3IAn2c0z5nlk/GaqUHdiSbTPKhrqRpv =G/HL -----END PGP SIGNATURE----- --=-=-=--