From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Dunn <dunni@gnu.org>
Subject: Bug in Recent Agenda Mod
Date: Mon, 20 Mar 2017 20:21:14 -0400
Message-ID: <87efxrv5s5.fsf@escafil>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dunni@gnu.org>) id 1cq7Yh-0000wI-65
	for emacs-orgmode@gnu.org; Mon, 20 Mar 2017 20:21:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dunni@gnu.org>) id 1cq7Yg-0002kD-9q
	for emacs-orgmode@gnu.org; Mon, 20 Mar 2017 20:21:55 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43613)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dunni@gnu.org>) id 1cq7Yg-0002k3-6p
	for emacs-orgmode@gnu.org; Mon, 20 Mar 2017 20:21:54 -0400
Received: from [2604:6000:1010:176:da4d:3352:bae5:f50e] (port=36950
	helo=escafil)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <dunni@gnu.org>) id 1cq7Yf-0002rb-PI
	for emacs-orgmode@gnu.org; Mon, 20 Mar 2017 20:21:53 -0400
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org


Commit d262ae53c966c7a745c0fa779149f9eb7486333d "org-agenda: Fix agenda standard name when going unsticky" sets org-agenda-buffer-name to "*Org Agenda*" if not in sticky.

However, org-agenda-redo sets org-agenda-sticky to nil before redoing the agenda command.

Steps to Reproduce:

1. Turn on org-agenda-sticky
2. Execute any agenda command that only involves org-agenda-list
   - Agenda is in buffer *Org Agenda(CMD)* (ex. *Org Agenda(d:)*)
3. Press 'g' (org-agenda-redo)
   - Agenda is now in *Org Agenda*

The included patch fixes this for sticky redo, and will have no effect for anything other than a sticky redo.

--
Ian Dunn

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index b618653d5..04e6685b5 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4076,6 +4076,7 @@ items if they have an hour specification like [h]h:mm."
   (catch 'exit
     (setq org-agenda-buffer-name
 	  (or org-agenda-buffer-tmp-name
+	      (and org-agenda-doing-sticky-redo org-agenda-buffer-name)
 	      (if org-agenda-sticky
 		  (cond ((and org-keys (stringp org-match))
 			 (format "*Org Agenda(%s:%s)*" org-keys org-match))