From mboxrd@z Thu Jan  1 00:00:00 1970
From: stardiviner <numbchild@gmail.com>
Subject: Re: [PATCH] Add support for Babel with Eshell, (updated PATCH)
Date: Mon, 04 Jun 2018 10:11:41 +0800
Message-ID: <87efhnpag2.fsf@gmail.com>
References: <87d0ysroer.fsf@gmail.com> <87bmecrod4.fsf@gmail.com>
	<87a7twrmyv.fsf@gmail.com> <87po2q5kqk.fsf@nicolasgoaziou.fr>
	<87h8o26orj.fsf@gmail.com> <87sh7lobc5.fsf@nicolasgoaziou.fr>
	<87d0yptjjm.fsf@gmail.com> <87h8nzlm9x.fsf@nicolasgoaziou.fr>
	<87sh7i2q88.fsf@gmail.com> <87in73o7et.fsf@nicolasgoaziou.fr>
	<87r2lr6mzg.fsf@gmail.com> <871sdpo5n7.fsf@nicolasgoaziou.fr>
Reply-To: numbchild@gmail.com
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53662)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <numbchild@gmail.com>) id 1fPeyL-0000lZ-Hf
	for emacs-orgmode@gnu.org; Sun, 03 Jun 2018 22:11:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <numbchild@gmail.com>) id 1fPeyH-0000y8-DB
	for emacs-orgmode@gnu.org; Sun, 03 Jun 2018 22:11:49 -0400
Received: from [218.75.119.140] (port=35902 helo=dark.localdomain)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <numbchild@gmail.com>) id 1fPeyH-0000xg-1O
	for emacs-orgmode@gnu.org; Sun, 03 Jun 2018 22:11:45 -0400
In-reply-to: <871sdpo5n7.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: org-mode <emacs-orgmode@gnu.org>


Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> Aha, Thanks, Nicolas, I almost forget this patch. That's great!
>
> Speaking of which, there's an issue in
> `org-babel-eshell-initiate-session'.
>
> First, it uses (get-buffer (current-buffer)), which is equivalent to
> (current-buffer). But, more importantly, it doesn't do anything with it?
> So what is the point of the `progn' in that function?

You're right.

It originally suppose to return the Eshell session buffer  (return value) to be used by other functions. But at last function `org-babel-eshell-initiate-session` seems still return `session`. So this `(get-buffer (current-buffer))` seems not necessary.

Can you remove it? Regenerate patches on my side is little kind of trouble.

>
> Regards,


-- 
[ stardiviner ] don't need to convince with trends.
       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3