From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Capture with date prompt defaults to yesterday
Date: Mon, 10 Jun 2019 11:22:31 +0200
Message-ID: <87ef41lrqg.fsf@nicolasgoaziou.fr>
References: <CAKuG=vtX01eFXkymVPbP4MK7Ym+oUm0UMtwwYZ7tP-3GDaEcCA@mail.gmail.com>
 <CAKuG=vuAs6-iHPzHg9LtptFZjj-DssFLfR-V7wZvxOxqEWZMdQ@mail.gmail.com>
 <CAKuG=vsqSf+KNDyx6=DujG4eiHtCH7Ptj+b48xiytYF998vadQ@mail.gmail.com>
 <87imth5bh5.fsf@nicolasgoaziou.fr>
 <CAKuG=vs3jN=tRWiH5vjAeJh3cnq+W9gTL7HJzGUEW=aheTeqyg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:42059)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1haGVn-0003Vk-9A
 for emacs-orgmode@gnu.org; Mon, 10 Jun 2019 05:22:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1haGVl-0005bj-9O
 for emacs-orgmode@gnu.org; Mon, 10 Jun 2019 05:22:43 -0400
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:34981)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
 id 1haGVj-0005Yk-Jq
 for emacs-orgmode@gnu.org; Mon, 10 Jun 2019 05:22:41 -0400
In-Reply-To: <CAKuG=vs3jN=tRWiH5vjAeJh3cnq+W9gTL7HJzGUEW=aheTeqyg@mail.gmail.com>
 (Neil Jerram's message of "Sun, 9 Jun 2019 11:40:53 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Neil Jerram <neiljerram@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>

Hello,

Neil Jerram <neiljerram@gmail.com> writes:

> Yes, it does make the default time noon.  But AFAICS the time of day
> doesn't actually matter in any of the Org source code where the result of
> org-get-cursor-date is used.  Have I missed a case where it does
> matter?

Probably not. I didn't check. But this could become a future gotcha.

> However, in the attached patch I've revised that so that the default time
> of day is <org-extend-today-until>:00am, i.e. it's the earliest time that
> Org treats as being that date.  WDYT?

I think this is better. I applied your patch. Thank you.

> Alternatively, we could refactor the code around where org-get-cursor-date
> is used to make it more explicit when the time of day doesn't matter, and
> look further if there are any cases where it does.

I think the current state is sufficient.

Regards,

-- 
Nicolas Goaziou