From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] ox-html: add option to restore old src block behaviour?
Date: Tue, 08 Oct 2019 11:31:41 +0200
Message-ID: <87eezneg76.fsf@nicolasgoaziou.fr>
References: <87h8553kwm.fsf@informationelle-selbstbestimmung-im-internet.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:36764)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1iHlqR-0002Rv-Uy
 for emacs-orgmode@gnu.org; Tue, 08 Oct 2019 05:31:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1iHlqQ-0006vM-Qb
 for emacs-orgmode@gnu.org; Tue, 08 Oct 2019 05:31:51 -0400
Received: from relay5-d.mail.gandi.net ([217.70.183.197]:58727)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
 id 1iHlqQ-0006s3-KD
 for emacs-orgmode@gnu.org; Tue, 08 Oct 2019 05:31:50 -0400
Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67])
 (Authenticated sender: admin@nicolasgoaziou.fr)
 by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 490B11C0018
 for <emacs-orgmode@gnu.org>; Tue,  8 Oct 2019 09:31:47 +0000 (UTC)
In-Reply-To: <87h8553kwm.fsf@informationelle-selbstbestimmung-im-internet.de>
 (Jens Lechtenboerger's message of "Sat, 21 Sep 2019 14:15:37 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Hello,

Jens Lechtenboerger <jens.lechtenboerger@fsfe.org> writes:

> The attached patch adds a new variable org-html-wrap-src-lines to
> control whether code tags should be added or not.

Thank you.

However, the patch is not right. Exporters do not use defcustoms
directly. Instead, you register them within :options-alist in the the
back-end definition, e.g., under :html-wrap-src-lines and then call
(plist-get info :html-wrap-src-lines) in the function. This allows to
control these options during publishing.

Also, this would need an entry in the manual, if only in the "options
for the exporters" subsection.

> I=E2=80=99m not sure whether :package-version 9.3 is correct.

It is correct. You can also use :safe t.

> Also, I set the value to t, which does not change the current
> functionality. However, for backwards compatibility (up to version
> 9.2.6), a value of nil would be preferable. Any thoughts?

I agree with the nil default value.

> +(defcustom org-html-wrap-src-lines t
> +  "If t, wrap individual lines of source blocks in \"code\" elements.

When non-nil, wrap...


Regards,

--=20
Nicolas Goaziou