From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: org-show-notification of org-clock.el broken on MS Windows
Date: Sun, 26 Jan 2020 09:12:40 +0100
Message-ID: <87eevmk553.fsf@gnu.org>
References: <85sgk52pck.wl-tim@datenknoten.me>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:50091)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <bzg@gnu.org>) id 1ivd2C-0001VR-7S
 for emacs-orgmode@gnu.org; Sun, 26 Jan 2020 03:12:45 -0500
In-Reply-To: <85sgk52pck.wl-tim@datenknoten.me> (Tim Schumacher's message of
 "Fri, 24 Jan 2020 10:08:59 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Tim Schumacher <tim@datenknoten.me>
Cc: emacs-orgmode@gnu.org

Hi Tim,

> * The function org-show-notification should be more robust. It should not fail
>   if it can't fire a notification for whatever reason.

Please send a patch if needed for this.

> * On MS Windows the function w32-notification-notify should be used.

I just fixed this one:
https://code.orgmode.org/bzg/org-mode/commit/8dd2984a

> Maybe someone has a quick fix, if not I can try my non existant elisp foo and hack
> together a patch tomorrow, but please be gentle with me.

We will, for sure :)

Thanks for raising this issue,

-- 
 Bastien