From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: attachment: link type export to HTML invalid attach dir
Date: Wed, 26 Feb 2020 16:22:41 +0100
Message-ID: <87eeuh8jb2.fsf@nicolasgoaziou.fr>
References: <PR1PR02MB47323A141AE248937F2FA7D4DAFB0@PR1PR02MB4732.eurprd02.prod.outlook.com>
 <HE1PR02MB3033EB926B8B582D176EB8E5DA330@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87muairkam.fsf@nicolasgoaziou.fr>
 <HE1PR02MB303324C053A518999533F379DA090@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87y2th0yc7.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033654FFD2F806D0B5EC83DDA1D0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <878sle1ng9.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033668D1D2CD40DB2C7E932DA1F0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <875zgausnb.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033AA077F9896011A161813DA1A0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87o8u2tbhg.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033FD69FC2C3EC94BA5ECD8DA1A0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87zhdlctsm.fsf@bzg.fr> <87a75lt7nc.fsf@nicolasgoaziou.fr>
 <87d0ag29kk.fsf@gnu.org> <87h7zrradl.fsf@nicolasgoaziou.fr>
 <871rqphaxo.fsf@nicolasgoaziou.fr> <87r1yp36ht.fsf@gnu.org>
 <87a75aeq3o.fsf@nicolasgoaziou.fr> <87v9nyoihw.fsf@gnu.org>
 <HE1PR02MB30330FEEF5C3D82873D690EDDAED0@HE1PR02MB3033.eurprd02.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:46784)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1j6yWb-0004Aw-RY
 for emacs-orgmode@gnu.org; Wed, 26 Feb 2020 10:23:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1j6yWX-0004FB-PO
 for emacs-orgmode@gnu.org; Wed, 26 Feb 2020 10:23:01 -0500
In-Reply-To: <HE1PR02MB30330FEEF5C3D82873D690EDDAED0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 ("Gustav =?utf-8?Q?Wikstr=C3=B6m=22's?= message of "Tue, 25 Feb 2020
 23:36:16 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Gustav =?utf-8?Q?Wikstr=C3=B6m?= <gustav@whil.se>
Cc: Bastien <bzg@gnu.org>, "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Hello,

Gustav Wikstr=C3=B6m <gustav@whil.se> writes:

> Expanding attachment-links in the buffer makes the link type no longer
> be attachment.

What makes you think that? The link type is preserved during the
substitution, according to the (concat "attachment" ...).

> I would prefer if we explicitly set the link type to
> files here instead. Storing intermediate state in an attachment link
> types makes less sense imo.
>
> One issue with the current way it's done is that images are treated
> differently between attachment links and file links. For HTML exports,
> file links are wrapped in a div with class figure where expanded
> attachment links are not.

It would be nice to investigate why this happens.

> Letting org-attach-expand-links do the full
> transform to file links would solve that issue. That also
> means :export is not needed for org-link-set-parameters.
>
> Patch attached if you agree to this.

Of course! This is what I suggested, like, 6 weeks ago (although, at
this time, I was thinking about having the substitution in "ox.el").

Regards,

--=20
Nicolas Goaziou