From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id q8eDAYM32F4KMgAA0tVLHw (envelope-from ) for ; Wed, 03 Jun 2020 23:51:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iAKSOII32F53ZAAA1q6Kng (envelope-from ) for ; Wed, 03 Jun 2020 23:51:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D02794014C for ; Wed, 3 Jun 2020 23:51:30 +0000 (UTC) Received: from localhost ([::1]:55800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgdAO-0001vh-UQ for larch@yhetil.org; Wed, 03 Jun 2020 19:51:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgd9l-0001t9-QT for emacs-orgmode@gnu.org; Wed, 03 Jun 2020 19:50:49 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:57524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgd9j-0007Ja-Lk for emacs-orgmode@gnu.org; Wed, 03 Jun 2020 19:50:49 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 059ADE191A; Wed, 3 Jun 2020 19:50:45 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=h667A2PVoywi ByUNBAs1dtXl6pM=; b=kUkzsHCG8Hq6sBcIJtv+h/OUA3SLC2sPuTYYs4ce6u1F VEMbwI1VjgEb238HFSSfA4Ii0zeC2QlcgIwHOYra735lOQ45BNNIqBfxWzYVUe1R 8Jn7VPBrgmYYV70zEjOOsy0Q6x+LfGr/I5hGAQlrdfx9FLcMm8edmn/NcoZuofE= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id F2647E1919; Wed, 3 Jun 2020 19:50:44 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=1zEUi8YnufRqQwlpmjgF2AJ4UUesjU/18j/cS7IVkwU=; b=BGzI5uK/EhEsiIu9+3J7u/mY2Cb9DnARgGcrvoytvt8EHWgoe8uXgo3ZskcKwdOgYVZwKCCO49UVv1Hs185zmSWLKpetzGRvceTeb9Edq8Y/+r7fMxiDUpe3SF5Jl4JIwvY7sHNGdoTLtFhicse3OAtf8A1t0A81GEharClvRvk= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 640CCE1918; Wed, 3 Jun 2020 19:50:42 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Mario Frasca Subject: Re: [PATCH] implementing `with' as a list, and respecting `deps' order. In-Reply-To: <75d44425-a3bf-f7e9-885d-8ca36e0b5205@anche.no> References: <43f4eda9-627d-4b36-7226-37b5458193e8@anche.no> <87sgfcx1hh.fsf@kyleam.com> <75d44425-a3bf-f7e9-885d-8ca36e0b5205@anche.no> Date: Wed, 03 Jun 2020 23:50:40 +0000 Message-ID: <87eeqvwvxr.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: 08F7B054-A5F5-11EA-AB4D-B0405B776F7B-24757444!pb-smtp20.pobox.com Received-SPF: pass client-ip=173.228.157.52; envelope-from=kyle@kyleam.com; helo=pb-smtp20.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/03 19:50:45 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=kUkzsHCG; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=BGzI5uK/; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: Y88rgd8c94CV Mario Frasca writes: > comments on the html page org-contribute.html: [...] > the procedure mentioned there guides me in creating several patch files,= =20 > one per commit.=C2=A0 it does not describe the "squashing" you suggested = me.=C2=A0=20 > I'm following your guide, but you might want to review the page yourself. My suggestion to you in the original thread [*] was in the context of updating a patch you sent based on reviewer feedback. The instructions on the org-contribute page are in the context of sending an initial series to the list, providing a two-patch series as an example. These are distinct things. If the change you're proposing conceptually fits into several commits (of course, how to divide things up is a subjective art), then please do so. As I said in the original thread: Just for clarity: In this case, I think the change proposed so far makes sense to present as a single commit. I'm not claiming that in general a patch series should be reduced to _one_ commit. I don't doubt that my descriptions or org-contribute's could be clearer. Suggestions on how to improve the org-contribute page are of course welcome, though I think it'd be a mistake to turn it into a Git tutorial. [*] https://yhetil.org/orgmode/874krvvdr3.fsf@kyleam.com/