From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wLiGN3wEMF+LCwAA0tVLHw (envelope-from ) for ; Sun, 09 Aug 2020 14:13:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WKwYM3wEMF9XFgAAbx9fmQ (envelope-from ) for ; Sun, 09 Aug 2020 14:13:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5F6AB94050F for ; Sun, 9 Aug 2020 14:13:16 +0000 (UTC) Received: from localhost ([::1]:40190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4m4Z-0004Mk-BS for larch@yhetil.org; Sun, 09 Aug 2020 10:13:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4m4E-0004Me-L2 for emacs-orgmode@gnu.org; Sun, 09 Aug 2020 10:12:54 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:34317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4m4D-0002SY-00 for emacs-orgmode@gnu.org; Sun, 09 Aug 2020 10:12:54 -0400 Received: by mail-wr1-x435.google.com with SMTP id f7so5846020wrw.1 for ; Sun, 09 Aug 2020 07:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZV7LMIhwTliB/i1SQXd+MalplMC3zGgYQPLYB/khzDg=; b=syDaDZ9vWypbMr8TX2sxh4RboUotfA49etQE3/ChbJ6g0UdHKY+qQQiGu9nPUEpsKz 8uyCYz1PiOjD0qzKPFadrIKv2vt/Rnqw1rNO0MS5UufJ1+mP3eIrpiRNUVd8J9hxR8AK 5uuXGKrDRs02tJExtn9mkGR7RwS2SbwCmmaIPbGMC6XLlBe7nSdazHazi9wIyjOTML4v O3gKhFcDIozXG1bXa0+zi9+HCMW4rkV8NefKQeJRWjvxI4DiBuCGDZ2RTJZqflgi2Ale 8q1ke+U+QV4h+TU7/nGYSYLE74y3WVpEwsmuz/bxR5qHwWgWg4tlSgTGE9AXwO7R/ZN+ mMDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ZV7LMIhwTliB/i1SQXd+MalplMC3zGgYQPLYB/khzDg=; b=C69UTmQy07SO39TWbimVrwhdwBZNsRq3RzmSgwqF06tViiRWkU3Muwwf6cTxLPuuV6 1bWwMwmGQKdFK88Yfm/06S+AilY5UPo+DARgCw8w99Mcwqej6qwmYpKLV1UYsPgjMkgq XyZCl18dwvLXEK51Ebue+YeNuk/I9Agu+NduSfk29KfFFb9HquUHxv8u5wfdnhxkHwiN cR7Q+08fyBEp7zfA8Zi5LjqLI4CUEwRa/lTKRR0T8EOrZFzE+IQqTG0JCnonnR+Rw6KF p2MOvksCgEceh3jeDjnARPB9UkzvPaN1p5uOwSVivE/Se0YCoa1XCh0jqkppzB2e9ss4 286A== X-Gm-Message-State: AOAM5309pMmn5RqPAJ08IF0bTDJf3L914/LKe0rw1Gejzcoyar2S3QSS XhEae4lI8aj6pZJHN/bcleKynMMk X-Google-Smtp-Source: ABdhPJxIonBNEc6sQwA/R8EoHvihOQtIhPpx8e5H5dUb8fLmZszkcIbBRp0hbis3ExGbrPnh9AZ2Ew== X-Received: by 2002:a5d:5273:: with SMTP id l19mr20345627wrc.257.1596982370051; Sun, 09 Aug 2020 07:12:50 -0700 (PDT) Received: from hirondell (2a01cb040b29800015848624b4c61618.ipv6.abo.wanadoo.fr. [2a01:cb04:b29:8000:1584:8624:b4c6:1618]) by smtp.gmail.com with ESMTPSA id q2sm17325636wro.8.2020.08.09.07.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2020 07:12:49 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Kyle Meyer Subject: Re: Bug#42184: org-fontify-whole-*-line in emacs 27 References: <878seotonm.fsf@kyleam.com> Date: Sun, 09 Aug 2020 16:12:48 +0200 In-Reply-To: <878seotonm.fsf@kyleam.com> (Kyle Meyer's message of "Sun, 09 Aug 2020 00:43:25 -0400") Message-ID: <87eeofaowv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=kevin.legouguec@gmail.com; helo=mail-wr1-x435.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=syDaDZ9v; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: woyseLupVEkS Kyle Meyer writes: >> +(defmacro org--extended-face (attributes) >> + "Make face that extends beyond end of line. >> + >> +Up to Emacs 26, all faces extended beyond end of line; getting >> +the same behaviour starting with Emacs 27 requires :extend t." >> + `(nconc ,attributes (when (>= emacs-major-version 27) '(:extend t)))) > > Two minor thoughts, neither really important: > > * Style nit-pick: s/when/and/, as the return value is of interest. OK; I didn't know 'when' had a "for side-effect only" connotation, I was using it as a shorthand for (if COND FORM nil). > ... the main thing I wonder is whether this kludge is necessary at all. > AFAICT unconditionally including :extend in the face spec doesn't seem > to bother earlier Emacs versions. Huh. Based on the discussion for bug#37774[1][2][3][4], I had assumed this kind of kludge would be necessary, but both Emacs 25.3 and 26.3 seem to evaluate and byte-compile the following snippet with no errors: #+begin_src elisp (defface foobar '((t (:extend t))) "Test extend in 26.3" :group 'org-faces) (custom-set-faces '(foobar ((t (:extend nil))) t)) #+end_src Obviously I'm all for removing this shim if it's not needed. From some light testing it looks like removing it breaks the customization widget, though? I'll post a revised patch as soon as someone can confirm or refute my observations. [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#41 [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#53 [3] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#71 [4] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#80 > Even if there is a reason to avoid > :extend on older versions, it's perhaps an overkill to add a > compatibility macro for just one spot. Right, that macro dates from an earlier patch, where I unconditionally set :extend t on a bunch of faces[5]. I agree that it's overkill for just org-block. [5] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=42184#17 > If org--extended-face stays, org-face.el should be adjusted to load > org-compat.el. (`make single' flags this.) (Ugh, I actually got that right in earlier patches.) Thanks for the review. As I said, I'll post an updated patch as soon as someone confirms or refutes my impression that :extend messes with the Customize widget for Emacs <27.