From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UGZBF44G5F+NbAAA0tVLHw (envelope-from ) for ; Thu, 24 Dec 2020 03:10:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QMwDE44G5F/AfgAAbx9fmQ (envelope-from ) for ; Thu, 24 Dec 2020 03:10:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E6668940418 for ; Thu, 24 Dec 2020 03:10:05 +0000 (UTC) Received: from localhost ([::1]:37628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksH0u-0007mO-1s for larch@yhetil.org; Wed, 23 Dec 2020 22:10:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksH0C-0007mD-Oa for emacs-orgmode@gnu.org; Wed, 23 Dec 2020 22:09:21 -0500 Received: from out0.migadu.com ([2001:41d0:2:267::]:14132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksH08-0000XP-B6; Wed, 23 Dec 2020 22:09:20 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1608779352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bPB6tQgnE0KVS0Z6EshxH4covjsmnyk/9Hj0l9DwEDw=; b=kN/vTG+I0zLU0B98y4yJ/elWwm7EKeuS9rdNHc6BR/9TPA/E5p+/WMjQ3FqqyiMjd9Cp7m LZGa3fnCWlGRdg+7njMVXiLNfW83bmwRsJYyBCxDrjkOFDwoCYxDngoMA10bKBt2VFp3VZ K698BOfg7CncKdHMfZRWkIQdFeF8OdIYfobXzIizLnNOi+YA+c1+UVaAd4HFCLDIIFNsMi 0LdUXmI6VlhpmXxBqb4ZxSOyixfRZjb40ju+rXk8LZ85FtvY0n7+8hznrFsk+fsgzq68Gd 2UCbSM7/JWRYRv5TpfTYPNDTk/l8mSzFwNoWdIgYPZzic4pU6A2FssAeOToDVg== From: Kyle Meyer To: TEC Subject: Re: [PATCH] org-plot abstractions and extension In-Reply-To: <87v9cstlze.fsf@gmail.com> References: <87imcrfntf.fsf@gmail.com> <87blijmnv9.fsf@gnu.org> <87lfhbhfhe.fsf@gmail.com> <87r1qp3fu1.fsf@gmail.com> <871rhxd2ib.fsf@gmail.com> <87r1pnoo5y.fsf@bzg.fr> <87lffv8oy5.fsf@gmail.com> <87zh2hosex.fsf@bzg.fr> <87im8tglbl.fsf@kyleam.com> <87zh25t8cj.fsf@gmail.com> <87y2hpt568.fsf@gmail.com> <87czz1gfje.fsf@kyleam.com> <87wnx8ud5k.fsf@gmail.com> <871rfgh36z.fsf@kyleam.com> <87v9cstlze.fsf@gmail.com> X-Woof-Patch: applied Message-ID: <87eejfhpd5.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Date: Thu, 24 Dec 2020 03:09:12 GMT Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=kyleam.com header.s=key1 header.b=kN/vTG+I; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E6668940418 X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: PvXX8Je9ZP7b TEC writes: > Kyle Meyer writes: > >> recent org-plot example from 8d5122fc5: >> [...] >> That could be rewritten as [...] > > Would you like me to bundle that change in somewhere? In my view it's fine to leave it as is (it's just an example that was fresh in my mind), but of course feel free to send a patch for it if you'd like. > One question, I saw Bastien say that we didn't want whitespace-only > commits, so how should whitespace-fixups be done? I think the idea is to avoid whitespace-only churn, particularly if the only goal is tab/space indentation consistency. In that case, you'd just leave it be unless you're changing the code for some other reason. On the other hand, I think a dedicated patch for the indentation fix you had in the first commit would be welcomed. The distinction is that in this case the code is simply misaligned: (mapcar (lambda (row) (org--plot/values-stats (mapcar #'string-to-number (cdr row)) hard-min hard-max)) table) I'd say that's worth fixing because it hurts readability. Also, in the process, it'd be good to move "table" to the next line because (to use lisp-mode's phrasing) it's "hidden behind a deeper element". > Subject: [PATCH] org-plot.el: fix compiler warnings Thanks. Applied (7a9a8a56a)... > > * lisp/org-plot.el (org--plot/values-stats): Replace `log10' with > `log'. > (org--plot/nice-frequency-pick): Replace obsolete `case' with `pcase`. ... with s/pcase/cl-case/ to match the final state of the code.