From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wDhGGqCyFmDBFQAA0tVLHw (envelope-from ) for ; Sun, 31 Jan 2021 13:37:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +OebFaCyFmDIMwAA1q6Kng (envelope-from ) for ; Sun, 31 Jan 2021 13:37:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BA884940275 for ; Sun, 31 Jan 2021 13:37:35 +0000 (UTC) Received: from localhost ([::1]:44776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6Cux-0006c0-9K for larch@yhetil.org; Sun, 31 Jan 2021 08:37:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6Cu3-0006bk-2r for emacs-orgmode@gnu.org; Sun, 31 Jan 2021 08:36:35 -0500 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:37533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6Cu0-0006aI-0Z for emacs-orgmode@gnu.org; Sun, 31 Jan 2021 08:36:34 -0500 Received: by mail-pl1-x62c.google.com with SMTP id q2so8464206plk.4 for ; Sun, 31 Jan 2021 05:36:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=9OwGgC6zhr4BMgY95OyBEa1mAX9o3nvbuYoYNZQ0D04=; b=ujqYnHMurKSqKhbkYznBJnHBv+OBoSAaFoD2R/Fp9NnDLYhoCFjzW+tnLrqaU7zyxO VuGHSvFwjwFVcLvSG8FuxODlufglQKGFgTHSesp5HP/1ecUOxKuVdVChEfNMcFaEkGco VN2x1ObWxiyucEz8nMddNnS0dj7khDelvqulO4Ba20Xo93d2sgaBZknCwl6PSXFV/T/K D5+dC/V8xwq7ITl2yQcb/o3wNTvjXt+SBguk7szZ1WFOrj8ZDxIBZBe1lgEBlc0GZNbx FLYiOu6AB8vJyCCZyGKmpV3h5CdrQ7/TVC/DaEkmcCjNCXY2ugzAHB3a5JIGwFXYoRSt pauQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=9OwGgC6zhr4BMgY95OyBEa1mAX9o3nvbuYoYNZQ0D04=; b=bsky2bd15Gd4ua40DwUukdsJCHxc8/URBbvNRGgHHml64EqELpPI82zNWSqEGd3dI9 qMrNl/ncYTzcmxhohr4Z4WeujlCbWBstmVzwoEAkAMyPHsjMUTGhZ3kYyuVafOX4QtOG fkmvOOOOuZmP0B8FynJzF6/7pAt5Xseykv3kj8KXQR56b8n0wkMAqUU5F7Z9L+/CBCx5 gBCBrNBRjIhL3Xm/qsMS6gDTntxqPQf6Ffs4fubRfNYljEBHsT24ZP48lzlPldcB5tYA N1hQ1R5E5WWFKHDvlywwWrj6yxn4PGRpMDesu1yzHZSYUih5Z2nnbCfHpqdY0YOHlx0r c+yg== X-Gm-Message-State: AOAM530xLNSi7Uh35UF9GJ63CxsC2JvFhgj/rOPRl2czHDBX55mDMH1d l5rpjoYWJsjFldHRa/k6rHTd9BjxtZ7Q3g== X-Google-Smtp-Source: ABdhPJxZhbhTMLPM8WaAWC/qoL4rFJXl9IUEnxzSG4Vz21Cmykg36cKBXelwQ3iha10RIi5RH2QwrA== X-Received: by 2002:a17:902:cece:b029:e1:1057:9cbe with SMTP id d14-20020a170902ceceb02900e110579cbemr13852430plg.31.1612100189081; Sun, 31 Jan 2021 05:36:29 -0800 (PST) Received: from localhost ([192.161.60.130]) by smtp.gmail.com with ESMTPSA id b18sm14848345pfi.173.2021.01.31.05.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Jan 2021 05:36:28 -0800 (PST) From: Ihor Radchenko To: Juan Manuel =?utf-8?Q?Mac=C3=ADas?= Subject: Re: org-attach-git don't automatically commit changes In-Reply-To: <878s89nt4z.fsf@posteo.net> References: <87czxn91dj.fsf@posteo.net> <87a6sr6mcq.fsf@localhost> <8735yiv926.fsf@posteo.net> <87wnvt4w62.fsf@localhost> <87r1m1o0vz.fsf@posteo.net> <87k0rt4bvc.fsf@localhost> <878s89nt4z.fsf@posteo.net> Date: Sun, 31 Jan 2021 21:40:35 +0800 Message-ID: <87eei14430.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=yantar92@gmail.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: orgmode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.56 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=ujqYnHMu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: BA884940275 X-Spam-Score: -2.56 X-Migadu-Scanner: scn0.migadu.com X-TUID: yyMRzQEtkWIS Juan Manuel Mac=C3=ADas writes: > Do you think a possible patch could simply consist of replacing (as I > have done) `(expand-file-name org-attach-id-dir)' by `(org-attach-dir)' > in `org-attach-git-commit'? This would allow you to handle attachment > dirs as individual git repos, regardless of :ID: or :DIR: properties, > since "[(org-attach-dir)] Return the directory associated with the > current outline node. First check for DIR property, then ID property > [...]". All the instances of (expand-file-name org-attach-id-dir) should be replaced. There are 3. That's not a big deal. What is more tricky is making sure that workflow for people using the old behaviour is not broken. Just changing to (org-attach-dir) will break existing git repos in org-attach-id-dir. This should also not be too hard (say, we can introduce a custom variable defaulting to old behaviour), but exact details may need to be discussed. In any case, if you provide a patch, it will encourage the org maintainers to join this discussion and proceed with changes. Best, Ihor