emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Tim Cross <theophilusx@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ol.el: Fix confusing variable name
Date: Fri, 30 Apr 2021 15:33:27 +1000	[thread overview]
Message-ID: <87eeesibcj.fsf@gmail.com> (raw)
In-Reply-To: <20210429221824.69965-1-me@bcc32.com>

"Aaron L. Zeng" <me@bcc32.com> writes:

> * ol.el (org-link--open-help): Fix a confusing variable name.  No
> behavior changes.
> ---
>  lisp/ol.el | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/lisp/ol.el b/lisp/ol.el
> index 62ea6d2bc..617223cb5 100644
> --- a/lisp/ol.el
> +++ b/lisp/ol.el
> @@ -1325,8 +1325,8 @@ PATH is the sexp to evaluate, as a string."
>    "Open a \"help\" type link.
>  PATH is a symbol name, as a string."
>    (pcase (intern path)
> -    ((and (pred fboundp) variable) (describe-function variable))
> -    ((and (pred boundp) function) (describe-variable function))
> +    ((and (pred fboundp) function) (describe-function function))
> +    ((and (pred boundp) variable) (describe-variable variable))
>      (name (user-error "Unknown function or variable: %s" name))))
>  (defun org-link--store-help ()

Hi Aaron,

thanks for the patch. It looks straight forward, does seem to be less
confusing and in-line with the intention of the code and is only a tiny
change, so I think it should be applied.


Tim Cross

  reply	other threads:[~2021-04-30  5:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 22:18 [PATCH] ol.el: Fix confusing variable name Aaron L. Zeng
2021-04-30  5:33 ` Tim Cross [this message]
2021-04-30  6:52   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeesibcj.fsf@gmail.com \
    --to=theophilusx@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).